From owner-freebsd-bugs@FreeBSD.ORG  Tue Feb 12 22:50:03 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7368216A468
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 12 Feb 2008 22:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 678D513C4E7
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 12 Feb 2008 22:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1CMo32N085795
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 12 Feb 2008 22:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1CMo3i5085794;
	Tue, 12 Feb 2008 22:50:03 GMT (envelope-from gnats)
Date: Tue, 12 Feb 2008 22:50:03 GMT
Message-Id: <200802122250.m1CMo3i5085794@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Sean Bruno <sbruno@miralink.com>
Cc: 
Subject: Re: kern/120569: [bge] [patch] Update dev id's for bge
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Sean Bruno <sbruno@miralink.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2008 22:50:03 -0000

The following reply was made to PR kern/120569; it has been noted by GNATS.

From: Sean Bruno <sbruno@miralink.com>
To: bug-followup@FreeBSD.org, sbruno@miralink.com
Cc:  
Subject: Re: kern/120569: [bge] [patch] Update dev id's for bge
Date: Tue, 12 Feb 2008 14:18:55 -0800

 This is a multi-part message in MIME format.
 --------------030009000500040406010701
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 I forgot to include this change for mii_physubr.c
 
 Apparently this adapter reports ife->ifm_data as == MII_NMEDIA
 
 Not sure if that is a bug or how it should be, but this is required 
 along with the previous patch.
 
 Sean
 
 --------------030009000500040406010701
 Content-Type: text/x-patch;
  name="mii.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="mii.diff"
 
 Index: /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c
 ===================================================================
 --- /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c (revision 3333)
 +++ /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c (revision 5102)
 @@ -121,11 +121,11 @@
  
  	/*
  	 * Table index is stored in the media entry.
  	 */
  
 -	KASSERT(ife->ifm_data >=0 && ife->ifm_data < MII_NMEDIA,
 +	KASSERT(ife->ifm_data >=0 && ife->ifm_data <= MII_NMEDIA,
  	    ("invalid ife->ifm_data (0x%x) in mii_phy_setmedia",
  	    ife->ifm_data));
  
  	anar = mii_media_table[ife->ifm_data].mm_anar;
  	bmcr = mii_media_table[ife->ifm_data].mm_bmcr;
 
 
 --------------030009000500040406010701--