From owner-p4-projects@FreeBSD.ORG Fri May 16 16:26:00 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5EE38106566B; Fri, 16 May 2008 16:26:00 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 211D4106566C for ; Fri, 16 May 2008 16:26:00 +0000 (UTC) (envelope-from snagg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EC0088FC13 for ; Fri, 16 May 2008 16:25:59 +0000 (UTC) (envelope-from snagg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m4GGPxcd030030 for ; Fri, 16 May 2008 16:25:59 GMT (envelope-from snagg@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m4GGPxxi030028 for perforce@freebsd.org; Fri, 16 May 2008 16:25:59 GMT (envelope-from snagg@FreeBSD.org) Date: Fri, 16 May 2008 16:25:59 GMT Message-Id: <200805161625.m4GGPxxi030028@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to snagg@FreeBSD.org using -f From: Vincenzo Iozzo To: Perforce Change Reviews Cc: Subject: PERFORCE change 141723 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2008 16:26:00 -0000 http://perforce.freebsd.org/chv.cgi?CH=141723 Change 141723 by snagg@snagg_macosx on 2008/05/16 16:25:31 Missing a lock if the app is not found in delete_pid Reviewed by: csjp Affected files ... .. //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_pipe.c#10 edit Differences ... ==== //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_pipe.c#10 (text) ==== @@ -439,7 +439,9 @@ free((app->app_auevents + i), M_AUDIT_PIPE_PRESELECT_EVENT); free(app, M_AUDIT_PIPE_PRESELECT); return (0); - } + }else + mtx_unlock(&audit_pipe_mtx); + return (ENOENT); }