From owner-freebsd-current Mon May 21 17: 1:41 2001 Delivered-To: freebsd-current@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 88A6C37B43E; Mon, 21 May 2001 17:01:39 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from spike.unixfreak.org (spike [63.198.170.139]) by bazooka.unixfreak.org (Postfix) with ESMTP id 35B763E0B; Mon, 21 May 2001 17:01:39 -0700 (PDT) To: David Malone Cc: freebsd-current@freebsd.org, alfred@freebsd.org Subject: Re: panic: mutex vm not owned In-Reply-To: <20010521213714.A54189@walton.maths.tcd.ie>; from dwmalone@maths.tcd.ie on "Mon, 21 May 2001 21:37:14 +0100" Date: Mon, 21 May 2001 17:01:39 -0700 From: Dima Dorfman Message-Id: <20010522000139.35B763E0B@bazooka.unixfreak.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David Malone writes: > On Mon, May 21, 2001 at 01:44:16AM -0700, Dima Dorfman wrote: > > > exit1 calls shmexit with vm_mtx held on line 228 of kern_exit.c > > (rev. 1.127). Actually, shmexit_myhook should always be called with > > vm_mtx held, so shm_delete_mapping can't assume it isn't held. > > The following seems to work. It's basically your patch, but it > removes the patch which was originally committed, adds an extra > assert, expands on one comment and grabs a mutex in one place > it seemed to be needed after removing the others. Great! I can confirm that this works for me. Alfred, any objections to me or David committing this? > + /* shm_delete_mappings requires this */ > + mtx_assert(&vm_mtx, MA_OWNED); That should be 'shm_delete_mapping'; no 's'. That's my fault. Thanks, Dima Dorfman dima@unixfreak.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message