From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 2 19:20:03 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A8741065672 for ; Mon, 2 Apr 2012 19:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4AB7E8FC18 for ; Mon, 2 Apr 2012 19:20:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q32JK3U2005144 for ; Mon, 2 Apr 2012 19:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q32JK3eO005137; Mon, 2 Apr 2012 19:20:03 GMT (envelope-from gnats) Resent-Date: Mon, 2 Apr 2012 19:20:03 GMT Resent-Message-Id: <201204021920.q32JK3eO005137@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Allen Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E353B10657D6 for ; Mon, 2 Apr 2012 19:13:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id CE4C08FC0C for ; Mon, 2 Apr 2012 19:13:16 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q32JDGtx032612 for ; Mon, 2 Apr 2012 19:13:16 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q32JDGnw032609; Mon, 2 Apr 2012 19:13:16 GMT (envelope-from nobody) Message-Id: <201204021913.q32JDGnw032609@red.freebsd.org> Date: Mon, 2 Apr 2012 19:13:16 GMT From: Allen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/166589: atacontrol incorrectly treats RAID10 and 0+1 the same X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2012 19:20:03 -0000 >Number: 166589 >Category: misc >Synopsis: atacontrol incorrectly treats RAID10 and 0+1 the same >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 02 19:20:02 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Allen >Release: 8.2 >Organization: >Environment: FreeBSD is01 8.2-STABLE FreeBSD 8.2-STABLE #0: Thu Sep 15 15:30:52 EDT 2011 root@:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Reference: http://www.freebsd.org/cgi/cvsweb.cgi/src/sbin/atacontrol/atacontrol.c?annotate=1.36.2.3 atacontrol.c commit on 25-Jan-2006, lines 413-427. Code was added to allow creation of RAID0+1 on ATA controllers available at the time. This code is checking for the user supplied strings "RAID0+1" and "RAID10" and treating them both the same. As a result, RAID10 arrays cannot be created on devices that support both levels -- unknown if there are any such devices supported by atacontrol. RAID10 and RAID0+1 are not the same thing. The comment in the commit implies that the author thinks they are. >How-To-Repeat: >Fix: 1. On controllers only supporting one of the two levels (0+1 or 10), display and expect the correct string. 2. Separate the two so that, if there are any controllers that do support both, the correct one can be chosen. ata_ioc_raid_config in sys/sys/ata.h will also need modified to support both AR_RAID01 and AR_RAID10. >Release-Note: >Audit-Trail: >Unformatted: