From owner-svn-src-all@FreeBSD.ORG Tue Jun 2 22:39:17 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1C79874D; Tue, 2 Jun 2015 22:39:17 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B0FF13CC; Tue, 2 Jun 2015 22:39:17 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t52MdG7l000268; Tue, 2 Jun 2015 22:39:16 GMT (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t52MdGPQ000267; Tue, 2 Jun 2015 22:39:16 GMT (envelope-from glebius@FreeBSD.org) Message-Id: <201506022239.t52MdGPQ000267@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: glebius set sender to glebius@FreeBSD.org using -f From: Gleb Smirnoff Date: Tue, 2 Jun 2015 22:39:16 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r283934 - head/sys/dev/iwi X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 22:39:17 -0000 Author: glebius Date: Tue Jun 2 22:39:16 2015 New Revision: 283934 URL: https://svnweb.freebsd.org/changeset/base/283934 Log: The argument passed to the iwi_update_wme() is softc, not ieee80211com. This fatal mismatch appeared to be absolutely harmless, since both structs have pointer to struct ifnet as their first member, and they both point to the same ifnet. And the first member is the only one used from the argument. Modified: head/sys/dev/iwi/if_iwi.c Modified: head/sys/dev/iwi/if_iwi.c ============================================================================== --- head/sys/dev/iwi/if_iwi.c Tue Jun 2 22:23:20 2015 (r283933) +++ head/sys/dev/iwi/if_iwi.c Tue Jun 2 22:39:16 2015 (r283934) @@ -1083,8 +1083,7 @@ iwi_wme_setparams(struct iwi_softc *sc, static void iwi_update_wme(void *arg, int npending) { - struct ieee80211com *ic = arg; - struct iwi_softc *sc = ic->ic_ifp->if_softc; + struct iwi_softc *sc = arg; IWI_LOCK_DECL; IWI_LOCK(sc);