From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 21:16:12 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5B79816A4CE; Tue, 22 Jun 2004 21:16:12 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A93D443D1D; Tue, 22 Jun 2004 21:16:11 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i5MLG7qG004879;
	Tue, 22 Jun 2004 23:16:08 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: John Baldwin <jhb@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 22 Jun 2004 17:12:13 EDT."
             <200406221712.13015.jhb@FreeBSD.org> 
Date: Tue, 22 Jun 2004 23:16:07 +0200
Message-ID: <4878.1087938967@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: freebsd-current@freebsd.org
cc: Christian Weisgerber <naddy@mips.inka.de>
Subject: Re: Optimized ether_crc32_be() 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 21:16:12 -0000

In message <200406221712.13015.jhb@FreeBSD.org>, John Baldwin writes:
>On Friday 18 June 2004 07:37 pm, Christian Weisgerber wrote:
>> Taken from kern/49957, here's a table-driven implementation of
>> ether_crc32_be() to complement the little-endian one.  For 6-byte
>> MAC addresses it's about five times faster than the double loop.
>>
>> Comments?
>
>Doesn't look like anyone responded.  Perhaps ask someone on sparc64 to test it 
>along with some simple multicast test?  (Use mtest to join a group, turn on 
>bmcastecho and then ping the multicast group to see if it responds?)

For things like this I would really advocate adding a regression
test over in src/tools/regression.

Please ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.