From owner-cvs-all@FreeBSD.ORG Mon Jul 19 10:39:24 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2B80916A4CF; Mon, 19 Jul 2004 10:39:24 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i6JAdMdc005231; Mon, 19 Jul 2004 06:39:22 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.12.11/8.12.11/Submit) id i6JAdIfX005230; Mon, 19 Jul 2004 06:39:18 -0400 (EDT) (envelope-from green) Date: Mon, 19 Jul 2004 06:39:17 -0400 From: Brian Fundakowski Feldman To: Alan Cox Message-ID: <20040719103917.GD1038@green.homeunix.org> References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <40FB718B.7080206@samsco.org> <20040719071147.GS18577@cs.rice.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040719071147.GS18577@cs.rice.edu> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: Scott Long cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 10:39:24 -0000 On Mon, Jul 19, 2004 at 02:11:47AM -0500, Alan Cox wrote: > On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote: > > This is a pretty darn big change to something that is so vital to so > > many drivers (not including busdma, which means that this touches nearly > > every driver). Who reviewed this? Was it discussed on a public mailing > > list? What kind of testing was done for it? If you can't answer these > > questions then I'm not terribly thrilled. > > > > I reviewed an earlier version of this and gave Brian some feedback. > > It is important to note that he added the new implementation side-by-side > with the old. By default, the old implementation is still used. So, I > wouldn't be too concerned. Aye, I didn't feel totally comfortable saying "Reviewed by:" since that was a while ago, but between alc and hmp who has been overhauling the contigmalloc() implementation in DFBSD there wasn't any concern that I know I hadn't addressed (and Dillon ignored my solicitation). -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\