From owner-freebsd-arch@FreeBSD.ORG Fri Sep 8 08:49:48 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E046316A4E1 for ; Fri, 8 Sep 2006 08:49:48 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6AC043D55 for ; Fri, 8 Sep 2006 08:49:47 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 71335 invoked from network); 8 Sep 2006 08:34:28 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 8 Sep 2006 08:34:28 -0000 Message-ID: <45012EAA.4010303@freebsd.org> Date: Fri, 08 Sep 2006 10:49:46 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Andrew Thompson References: <450035AD.3040600@freebsd.org> <20060908010835.GA6334@heff.fud.org.nz> In-Reply-To: <20060908010835.GA6334@heff.fud.org.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, yar@comp.chem.msu.su, freebsd-arch@freebsd.org Subject: Re: Moving ethernet VLAN tags into the mbuf packet header (from mtags) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2006 08:49:49 -0000 Andrew Thompson wrote: > On Thu, Sep 07, 2006 at 05:07:25PM +0200, Andre Oppermann wrote: >> With the recent addition of a 16bit field for TSO into the mbuf packet >> header we've got 16bits left over. I've reserved these bits for the >> ethernet VLAN tagging of packet to do away with the allocated mbuf mtag. >> >> The change is rather mechanical. Patch available here: >> >> http://people.freebsd.org/~andre/vlan_pkthdr-20060907.diff >> > > RCS file: /home/ncvs/src/sys/netgraph/ng_vlan.c,v > retrieving revision 1.3 > diff -u -p -r1.3 ng_vlan.c > --- netgraph/ng_vlan.c 20 Apr 2005 14:19:20 -0000 1.3 > +++ netgraph/ng_vlan.c 7 Sep 2006 15:03:58 -0000 > > <...> > > - vlan = EVL_VLANOFTAG(VLAN_TAG_VALUE(mtag)); > + vlan = m->m_pkthdr.ether_vlan; > (void)&evl; /* XXX silence GCC */ > > I think this is a typeo, EVL_VLANOFTAG is still needed. I like the > change and it helps out a few related projects that people are working > on. Fixed. Thanks for the review! -- Andre