From owner-cvs-all@FreeBSD.ORG  Tue Jan 25 15:39:46 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A8E4A16A4CE; Tue, 25 Jan 2005 15:39:46 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E13F443D48; Tue, 25 Jan 2005 15:39:45 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0PFdig1086670;
	Tue, 25 Jan 2005 16:39:44 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 25 Jan 2005 09:37:29 CST."
             <20050125153729.GF5662@lum.celabo.org> 
Date: Tue, 25 Jan 2005 16:39:44 +0100
Message-ID: <86669.1106667584@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Andrey Chernov <ache@nagual.pp.ru>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sys_generic.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2005 15:39:46 -0000

In message <20050125153729.GF5662@lum.celabo.org>, "Jacques A. Vidrine" writes:
>On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote:
>> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote:
>> >     sys/kern             sys_generic.c 
>> >   Log:
>> >   Previously a read of zero bytes got handled in devfs:vop_read() but I
>> >   missed that when the vnode bypass was introduced.
>> >   
>> >   Deal with zero length transfers before we even get to fo_ops->fo_read().
>> 
>> Please back it out. Zero bytes read may affect atime, now not.
>
>I do not think that a zero byte read should not affect atime.

Explain to me then why open+mmap doesn't affect atime isn't a bigger problem ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.