From owner-freebsd-bugs@FreeBSD.ORG Thu Nov 11 06:00:23 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 697181065672 for ; Thu, 11 Nov 2010 06:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 29D448FC17 for ; Thu, 11 Nov 2010 06:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAB60MuQ022163 for ; Thu, 11 Nov 2010 06:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAB60MRs022146; Thu, 11 Nov 2010 06:00:22 GMT (envelope-from gnats) Resent-Date: Thu, 11 Nov 2010 06:00:22 GMT Resent-Message-Id: <201011110600.oAB60MRs022146@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Ronald F.Guilmette" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E8DB106566B for ; Thu, 11 Nov 2010 05:54:17 +0000 (UTC) (envelope-from rfg@tristatelogic.com) Received: from outgoing.tristatelogic.com (segfault.tristatelogic.com [69.62.255.118]) by mx1.freebsd.org (Postfix) with ESMTP id 20A388FC18 for ; Thu, 11 Nov 2010 05:54:16 +0000 (UTC) Received: by segfault.tristatelogic.com (Postfix, from userid 1237) id 20E8BBDC35; Wed, 10 Nov 2010 21:54:15 -0800 (PST) Message-Id: <20101111055415.20E8BBDC35@segfault.tristatelogic.com> Date: Wed, 10 Nov 2010 21:54:15 -0800 (PST) From: "Ronald F.Guilmette" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/152131: Useless code in script.c (part 1) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Ronald F.Guilmette" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 06:00:23 -0000 >Number: 152131 >Category: bin >Synopsis: Useless code in script.c (part 1) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Nov 11 06:00:22 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Ronald F. Guilmette >Release: FreeBSD 7.0-RELEASE i386 >Organization: Infinite Monkeys & Co. >Environment: System: FreeBSD segfault.tristatelogic.com 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Tue Aug 5 02:38:40 PDT 2008 root@segfault.monkeys.com:/usr/src/sys/i386/compile/rfg20080805 i386 >Description: script.c does pointless zero-length writes to its child (shell) process. Also, an EOF on stdin should probably terminate everything. >How-To-Repeat: Look at the code. >Fix: *** script.c.orig 2004-02-15 09:30:13.000000000 -0800 --- script.c 2010-11-10 21:49:21.000000000 -0800 *************** *** 179,186 **** if (n > 0 && FD_ISSET(STDIN_FILENO, &rfd)) { cc = read(STDIN_FILENO, ibuf, BUFSIZ); ! if (cc < 0) break; - if (cc == 0) - (void)write(master, ibuf, 0); if (cc > 0) { (void)write(master, ibuf, cc); --- 179,184 ---- if (n > 0 && FD_ISSET(STDIN_FILENO, &rfd)) { cc = read(STDIN_FILENO, ibuf, BUFSIZ); ! if (cc <= 0) break; if (cc > 0) { (void)write(master, ibuf, cc); >Release-Note: >Audit-Trail: >Unformatted: