From owner-cvs-all@FreeBSD.ORG  Tue Aug 22 20:37:28 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8E41916A4DD;
	Tue, 22 Aug 2006 20:37:28 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E2CEB43D49;
	Tue, 22 Aug 2006 20:37:26 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k7MKa0WX044200;
	Tue, 22 Aug 2006 14:36:01 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 22 Aug 2006 14:36:05 -0600 (MDT)
Message-Id: <20060822.143605.1102534622.imp@bsdimp.com>
To: ru@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20060822101012.GC43494@rambler-co.ru>
References: <20060822082237.GC41304@rambler-co.ru>
	<20060822094452.GJ12848@cdnetworks.co.kr>
	<20060822101012.GC43494@rambler-co.ru>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Tue, 22 Aug 2006 14:36:02 -0600 (MDT)
Cc: pyunyh@gmail.com, src-committers@freebsd.org, cvs-src@freebsd.org,
	cvs-all@freebsd.org, glebius@freebsd.org, yongari@freebsd.org
Subject: Re: cvs commit: src/sys/dev/em if_em.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2006 20:37:28 -0000

In message: <20060822101012.GC43494@rambler-co.ru>
            Ruslan Ermilov <ru@FreeBSD.org> writes:
: It's still a watchdog event.  We can make it a separate counter,
: like watchdog_tx_event, and not add it to oerrors, but still show
: it in em_print_hw_stats().  It'd be useful to have this statistics
: available.

I've noticed some drivers have started to export stats via sysctls in
the dev tree.  Maybe that's where it should go?

I've used it for cbb, for example, to report things that are usually
hidden behind bootverbose (more could be useful here):

dev.cbb.1.pribus: 6
dev.cbb.1.secbus: 7
dev.cbb.1.subbus: 7

the code is real simple in the init routine to hook up these sysctl to
a softc variable...

Warner