From owner-freebsd-current@FreeBSD.ORG Sun Sep 5 14:37:11 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BA6616A4CE for ; Sun, 5 Sep 2004 14:37:11 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id F23AA43D49 for ; Sun, 5 Sep 2004 14:37:10 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i85EYNxk005750; Sun, 5 Sep 2004 10:34:23 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i85EYNTi005747; Sun, 5 Sep 2004 10:34:23 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sun, 5 Sep 2004 10:34:22 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Maxim Maximov In-Reply-To: <413AC8F1.9020601@mcsi.pp.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org Subject: Re: [PATCH] poll() hang with X apps X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2004 14:37:11 -0000 On Sun, 5 Sep 2004, Maxim Maximov wrote: > > Yeah, I had a good idea about what the problem might be, but I couldn't > > reproduce it here. Happily, Doug could and was willing to spend a lot of > > time with the debugger to track stuff down. Turns out it may have been a > > potential race I tagged when I was originally reviewing that element of > > socket locking, but hadn't yet had a chance to revisit. If the patch > > fixes it, wonderful! If not, there are one or two other things in the > > polling/select code that could use review. Assuming this patch does fix > > the problem for you (it did for Doug), I'll get it merged into HEAD > > tomorrow, and RELENG_5 a few days later. > > > > Thanks for your bug report, and we'll see how it goes :-). > > It goes very well. Easily reproducible xscreensaver hacks hangs > described by Doug are gone for me too. I believe the patch also solves > my dockapp problems. I haven't seen any wmdockapps hangs yet, but they > are harder to reproduce, so only time will tell. > > I guess this patch should be merged anyway. At least for xscreensaver > related hangs :) Wonderful. I've merged this to HEAD and put it on the RELENG_5 MFC path to merge in a couple of days. Thanks! Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research