From owner-cvs-all@FreeBSD.ORG Tue Aug 22 21:14:30 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 480CF16A4E5; Tue, 22 Aug 2006 21:14:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19F7443D73; Tue, 22 Aug 2006 21:14:28 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7MLENEJ049343; Tue, 22 Aug 2006 17:14:23 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Tue, 22 Aug 2006 17:14:16 -0400 User-Agent: KMail/1.9.1 References: <20060822082237.GC41304@rambler-co.ru> <20060822101012.GC43494@rambler-co.ru> <20060822.143605.1102534622.imp@bsdimp.com> In-Reply-To: <20060822.143605.1102534622.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608221714.17544.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 22 Aug 2006 17:14:24 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1708/Tue Aug 22 08:43:00 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: pyunyh@gmail.com, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, glebius@freebsd.org, ru@freebsd.org, yongari@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2006 21:14:30 -0000 On Tuesday 22 August 2006 16:36, M. Warner Losh wrote: > In message: <20060822101012.GC43494@rambler-co.ru> > Ruslan Ermilov writes: > : It's still a watchdog event. We can make it a separate counter, > : like watchdog_tx_event, and not add it to oerrors, but still show > : it in em_print_hw_stats(). It'd be useful to have this statistics > : available. > > I've noticed some drivers have started to export stats via sysctls in > the dev tree. Maybe that's where it should go? > > I've used it for cbb, for example, to report things that are usually > hidden behind bootverbose (more could be useful here): > > dev.cbb.1.pribus: 6 > dev.cbb.1.secbus: 7 > dev.cbb.1.subbus: 7 > > the code is real simple in the init routine to hook up these sysctl to > a softc variable... em already has several: dev.em.0.debug_info: -1 dev.em.0.stats: -1 dev.em.0.rx_int_delay: 0 dev.em.0.tx_int_delay: 66 dev.em.0.rx_abs_int_delay: 66 dev.em.0.tx_abs_int_delay: 66 -- John Baldwin