From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 22 21:00:02 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B04FFA47 for ; Sat, 22 Mar 2014 21:00:02 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 831F7754 for ; Sat, 22 Mar 2014 21:00:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2ML02GF049346 for ; Sat, 22 Mar 2014 21:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2ML02XC049345; Sat, 22 Mar 2014 21:00:02 GMT (envelope-from gnats) Date: Sat, 22 Mar 2014 21:00:02 GMT Message-Id: <201403222100.s2ML02XC049345@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Nikolai Lifanov Subject: Re: ports/187453: [maintainer] [update] [patch] sysutils/ansible 1.5.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Nikolai Lifanov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Mar 2014 21:00:02 -0000 The following reply was made to PR ports/187453; it has been noted by GNATS. From: Nikolai Lifanov To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/187453: [maintainer] [update] [patch] sysutils/ansible 1.5.2 Date: Sat, 22 Mar 2014 16:57:09 -0400 -------- Original Message -------- Subject: Re: ports/187453: [maintainer] [update] [patch] sysutils/ansible 1.5.2 Date: 2014-03-22 16:07 From: Nikolai Lifanov To: pawel@freebsd.org Cc: freebsd-ports-bugs@freebsd.org On 2014-03-22 15:30, pawel@FreeBSD.org wrote: > Synopsis: [maintainer] [update] [patch] sysutils/ansible 1.5.2 > > State-Changed-From-To: open->feedback > State-Changed-By: pawel > State-Changed-When: Sat Mar 22 19:26:39 UTC 2014 > State-Changed-Why: > DIstfile size is wrong, please check contents of tarball for malicious > content. Same thing with 1.5.2, this is worrisome... > > ===> License GPLv3 accepted by the user ===> ansible-1.5.3 depends > on > file: /usr/local/sbin/pkg - found => ansible-1.5.3.tar.gz doesn't seem > to exist in /usr/ports/distfiles/. => Attempting to fetch > http://releases.ansible.com/ansible/ansible-1.5.3.tar.gz fetch: > http://releases.ansible.com/ansible/ansible-1.5.3.tar.gz: size > mismatch: > expected 542711, actual 542687 => Attempting to fetch > ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/ansible-1.5.3.tar.gz > fetch: > ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/ansible-1.5.3.tar.gz: > File unavailable (e.g., file not found, no access) => Couldn't fetch it > - please try to retrieve this => port manually into > /usr/ports/distfiles/ and try again. *** Error code 1 > > Stop. make: stopped in /home/corn/ansible > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=187453 I can confirm that *both* distfiles have been rerolled. The distfile for 1.5.2 has the same contents, compress ratio, archive size, etc. down to the letter, but the checksum doesn't match. For 1.5.3, there really is a difference: Index: ansible-1.5.3/library/packaging/apt_repository ================================================================== --- ansible-1.5.3/library/packaging/apt_repository +++ ansible-1.5.3/library/packaging/apt_repository @@ -351,13 +351,13 @@ def get_add_ppa_signing_key_callback(module): def _run_command(command): module.run_command(command, check_rc=True) if module.check_mode: - return _run_command + return None else: - return None + return _run_command def main(): module = AnsibleModule( argument_spec=dict( This is really terrible and happens all the time... I'm going to move away from the project download site and back to github snapshots... So, please hold for a new patch. - Nikolai Lifanov