From owner-freebsd-hackers@FreeBSD.ORG  Tue May 26 21:20:04 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 72C1A1065675
	for <freebsd-hackers@freebsd.org>; Tue, 26 May 2009 21:20:03 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 52BA68FC12
	for <freebsd-hackers@freebsd.org>; Tue, 26 May 2009 21:20:03 +0000 (UTC)
	(envelope-from des@des.no)
Received: from ds4.des.no (cm-84.215.252.34.getinternet.no [84.215.252.34])
	by smtp.des.no (Postfix) with ESMTP id 562456D41D;
	Tue, 26 May 2009 23:20:02 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 45F81844BD; Tue, 26 May 2009 23:20:02 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Jakub Lach <jakub_lach@mailplus.pl>
References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no>
Date: Tue, 26 May 2009 23:20:01 +0200
In-Reply-To: <86prdvipwe.fsf@ds4.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8rg?=
	=?utf-8?Q?rav=22's?= message of "Tue, 26 May 2009 22:13:21 +0200")
Message-ID: <86my8z8su6.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org
Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file
	symlink) vulnerability
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2009 21:20:05 -0000

Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> Like bde@ pointed out, the patch is incorrect.  It moves the test for
> v_type !=3D VDIR up to a point where, in the case of a symlink, v_type is
> always (by definition) VLNK.

Hmm, actually, symlinks are resolved in namei(), not lookup().  This is
not going to be pretty.  I'll be back later...

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no