From owner-cvs-all@FreeBSD.ORG Wed May 28 06:03:09 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C20281065670; Wed, 28 May 2008 06:03:09 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101]) by mx1.freebsd.org (Postfix) with ESMTP id F2E648FC13; Wed, 28 May 2008 06:03:08 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (localhost [127.0.0.1]) by zim.MIT.EDU (8.14.2/8.14.2) with ESMTP id m4S63Xu3004821; Wed, 28 May 2008 02:03:33 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by zim.MIT.EDU (8.14.2/8.14.2/Submit) id m4S63XXh004820; Wed, 28 May 2008 02:03:33 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Wed, 28 May 2008 02:03:33 -0400 From: David Schultz To: d@delphij.net Message-ID: <20080528060333.GA4699@zim.MIT.EDU> Mail-Followup-To: d@delphij.net, Maxim Sobolev , Xin LI , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, re@FreeBSD.ORG References: <200805272004.m4RK4SZt029194@repoman.freebsd.org> <483C7FF2.6000607@FreeBSD.org> <483C977F.20105@delphij.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <483C977F.20105@delphij.net> Cc: Maxim Sobolev , src-committers@FreeBSD.ORG, re@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Xin LI Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memrchr.c src/sys/sys param.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2008 06:03:09 -0000 On Tue, May 27, 2008, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Maxim Sobolev wrote: > | Xin LI wrote: > |> delphij 2008-05-27 20:04:27 UTC > |> > |> FreeBSD src repository > |> > |> Modified files: (Branch: RELENG_6) > |> include string.h lib/libc/string > |> Makefile.inc memchr.3 sys/sys param.h Added > |> files: (Branch: RELENG_6) > |> lib/libc/string memrchr.c Log: > |> MFC: Add memrchr(3). > | > | I think this is not very good idea to MFC that into stable releases 6.x > | and 7.x. The reason is that configure scripts for some packages might > | detect up this API and enable it. Which means that some binary-only > | packages build for say 6.4 won't work on 6.3 and down. AFAIK, both > | forward and backward compatibility is required (or at least desired?) > | for stable branches. > | > | While it's "nice-to-have" feature, I see no pressing need to MFC this > | interface. > > I don't think so, perhaps I am wrong, but do we really want absolutely > no *new* features on -STABLE branches? ISTR that in prior discussions on symbol versioning, the consensus was that there's nothing wrong with adding new APIs in -STABLE branches, but of course apps that use the new features won't be backwards-compatible. By the way, one catch is that once you MFC symbols in the FBSD_1.1 namespace, any new symbols in the same library need to go in FBSD_1.2. We do guarantee that public namespaces do not change across stable branches. This is important for API-checking tools like appcert: even if you can't prevent problems like the one described previously, at least you have some assurance as to which versions of FreeBSD will run your app.