From owner-freebsd-ports Thu Apr 6 06:08:42 1995 Return-Path: ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA26004 for ports-outgoing; Thu, 6 Apr 1995 06:08:42 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id GAA25998 for ; Thu, 6 Apr 1995 06:08:40 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.9/8.6.9) id GAA24116; Thu, 6 Apr 1995 06:08:30 -0700 Date: Thu, 6 Apr 1995 06:08:30 -0700 Message-Id: <199504061308.GAA24116@silvia.HIP.Berkeley.EDU> To: crtb@upcoming.dcrt.nih.gov CC: ports@FreeBSD.org In-reply-to: <199504061210.IAA02118@upcoming.dcrt.nih.gov> (message from Chuck Bacon on Thu, 6 Apr 1995 08:10:09 -0400) Subject: Re: Error in GUIDELINES From: asami@cs.berkeley.edu (Satoshi Asami/=?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: ports-owner@FreeBSD.org Precedence: bulk * I suppose nobody with the brainpower to compose a port would fall * for this one, but in sec. 0.2, it says: * #ifdef _HAVE_PARAM_H * #include * #endif * which is wrong. The conditional is backward; it should be #ifndef. Um, I'm afraid you're wrong here. If you read the comments right after this piece of code, it says "add -D_HAVE_PARAM_H to CFLAGS in Makefile". This is because some systems don't have . * Furthermore the conditional should be omitted, since the same * conditional surrounds the entirety of . That's _SYS_PARAM_H, not _HAVE_PARAM_H. :) Satoshi