From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Feb 25 21:00:01 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DEC1CF1B
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Tue, 25 Feb 2014 21:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A06B118A3
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Tue, 25 Feb 2014 21:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1PL01Vj004456
 for <freebsd-ports-bugs@freefall.freebsd.org>; Tue, 25 Feb 2014 21:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1PL010k004455;
 Tue, 25 Feb 2014 21:00:01 GMT (envelope-from gnats)
Resent-Date: Tue, 25 Feb 2014 21:00:01 GMT
Resent-Message-Id: <201402252100.s1PL010k004455@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Derek Kulinski <takeda@takeda.tk>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3C3DEEC6
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Feb 2014 20:57:13 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:4])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 28A951878
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Feb 2014 20:57:13 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
 by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1PKvDRw062597
 for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Feb 2014 20:57:13 GMT
 (envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
 by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1PKvDa8062596;
 Tue, 25 Feb 2014 20:57:13 GMT (envelope-from nobody)
Message-Id: <201402252057.s1PKvDa8062596@cgiserv.freebsd.org>
Date: Tue, 25 Feb 2014 20:57:13 GMT
From: Derek Kulinski <takeda@takeda.tk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/187073: net/nss-pam-ldapd: service nslcd status always returns 0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Feb 2014 21:00:01 -0000


>Number:         187073
>Category:       ports
>Synopsis:       net/nss-pam-ldapd: service nslcd status always returns 0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 25 21:00:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Derek Kulinski
>Release:        FreeBSD 10.0-RELEASE
>Organization:
>Environment:
FreeBSD salt-testing 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
service nslcd status always returns 0, causing automated tools such as saltstack in my case to assume the service is running when it is not.
>How-To-Repeat:
root@salt-testing:~ # /usr/local/etc/rc.d/nslcd status
nslcd is running with PID 67408.
root@salt-testing:~ # echo $?
0
root@salt-testing:~ # /usr/local/etc/rc.d/nslcd stop
Stopping nslcd.
Waiting for PIDS: 67408.
root@salt-testing:~ # /usr/local/etc/rc.d/nslcd status
nslcd not running?
root@salt-testing:~ # echo $?
0

>Fix:
The least invasive fix is to add return 1 when the service is not running, like here:

nslcd_status()
{
        nslcd_findpid
        if [ ! ${mypid} = '' ]; then
                echo "${name} is running with PID ${mypid}.";
        else
                echo "${name} not running?";
                return 1
        fi
}


>Release-Note:
>Audit-Trail:
>Unformatted: