From owner-cvs-src@FreeBSD.ORG Sun Oct 10 15:41:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B518216A4CE; Sun, 10 Oct 2004 15:41:56 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D7EA43D31; Sun, 10 Oct 2004 15:41:56 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i9AFfqvo068338; Sun, 10 Oct 2004 17:41:54 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <41695833.3050500@DeepCore.dk> Date: Sun, 10 Oct 2004 17:41:39 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <89782.1097422612@critter.freebsd.dk> In-Reply-To: <89782.1097422612@critter.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Takahashi Yoshihiro cc: cvs-all@FreeBSD.ORG cc: sos@FreeBSD.ORG Subject: Re: cvs commit: src/sys/geom geom_pc98.c src/sys/dev/ata ata-all.h ata-cbus.c ata-disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2004 15:41:56 -0000 Poul-Henning Kamp wrote: > In message <20041009.023958.41719880.nyan@jp.FreeBSD.org>, Takahashi Yo= shihiro=20 > writes: >=20 >>In article <200410071737.i97Hb9TU038301@repoman.freebsd.org> >>S=F8ren Schmidt writes: >> >> >>>sos 2004-10-07 17:37:09 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/geom geom_pc98.c=20 >>> sys/dev/ata ata-all.h ata-cbus.c ata-disk.c=20 >>> Log: >>> Move the PC98 specific geometry "gunk" to geom_pc98.c where it belon= gs. >>> This also adds support for bigger disks on the controller I have acc= ess to, >>> and maybe others if I understood the adhoc methods used on those. >>> =20 >>> Those with more PC98 bigdrive controllers it is hereby invited to ad= d/fix >>> support for those in geom_pc98.c and not using #ifdef PC98 all over = the place. >> >>This broke non-ATA disk supports. We need to use different way for >>geometry translation between ATA and non-ATA disks. And, your >>'BigDrive' support has some problems, it cannot use 'BigDrive' as root >>filesystem and it is incompatibility with the other OSs. >=20 >=20 > Then conditionalize the code in geom_pc98 on the provider name starting= > with "ad". I allready did so :) > All PC98 disk layout relevant code should be in geom_pc98 and not > in diskdrivers. Exactly! However there is fripe with fdisk_pc98 and sysinstall it seems, dunno=20 about those as they are way out of my territory... --=20 -S=F8ren