From owner-freebsd-arch@FreeBSD.ORG Thu Apr 16 17:03:33 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20070106566B; Thu, 16 Apr 2009 17:03:33 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id A72BE8FC0A; Thu, 16 Apr 2009 17:03:32 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id n3GH3Voa031290; Thu, 16 Apr 2009 19:03:31 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.3/8.14.3/Submit) id n3GH3VWj031289; Thu, 16 Apr 2009 19:03:31 +0200 (CEST) (envelope-from marius) Date: Thu, 16 Apr 2009 19:03:31 +0200 From: Marius Strobl To: John Baldwin Message-ID: <20090416170331.GA30118@alchemy.franken.de> References: <200904151324.06754.jhb@freebsd.org> <200904151613.50568.jhb@freebsd.org> <200904151737.09769.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200904151737.09769.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: arch@freebsd.org, Marcel Moolenaar Subject: Re: Enabling interrupt filters by default X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2009 17:03:33 -0000 On Wed, Apr 15, 2009 at 05:37:09PM -0400, John Baldwin wrote: > On Wednesday 15 April 2009 4:36:30 pm Marcel Moolenaar wrote: > > > > On Apr 15, 2009, at 1:13 PM, John Baldwin wrote: > > > > > On Wednesday 15 April 2009 2:04:14 pm Marcel Moolenaar wrote: > > >> > > >> On Apr 15, 2009, at 10:24 AM, John Baldwin wrote: > > >> > > >>> A while ago I changed the interrupt code in 8.x such that all the MD > > >>> code was > > >>> the same for both the INTR_FILTER and non-INTR_FILTER case. I would > > >>> like to > > >>> flip the switch to enable INTR_FILTER by default. Any objections? > > >> > > >> Last time it was found to be not working. Did we fix it? > > > > > > Err, when was that? > > > > August 2007. > > I rototilled all the MD interrupt code to make both the filter and !filter MD > code identical and both sets use the same callout routines (post_filter, > etc.) in April 2008. > > > > I know folks have used it on amd64 and i386 ok and I have > > > tested it on both of those platforms. One of the arm kernel configs > > > uses it > > > by default. > > > > There was interrupt starvation on sparc64. There were also > > issues with permanently masking stray interrupts. This is > > problematic when interrupts are shared and there is at least > > 1 filter on it. > > > > FYI, > > The MD interrupt code has changed quite a bit since then and I explicitly > worked with marius@ and others to test the aforementioned changes (though > various platforms may have only tested the !filter case at the time). The MI part of INTR_FILTER still doesn't work properly when multiple filters share one interrupt, resulting in a hang during device attachment. After reviewing the INTR_FILTER code back in August 2007 scottl@ wrote a private mail to marcel@ and me confirming that problem and saying he even found more and even excusing for having pushed the switch to INTR_FILTER for 7.0. Given that the INTR_FILTER code in kern_intr.c for the most part seems unchanged since piso@ committed it probably means that these problems still exist today. Apart from the problem when filters share an interrupt, INTR_FILTER looked good on sparc64 though last time I tested. Marius