From owner-cvs-all@FreeBSD.ORG Tue Dec 14 06:11:16 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E91F516A508 for ; Tue, 14 Dec 2004 06:11:15 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3686443D3F for ; Tue, 14 Dec 2004 06:11:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 12421 invoked from network); 14 Dec 2004 06:11:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 14 Dec 2004 06:11:14 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iBE6B1XF091443; Tue, 14 Dec 2004 01:11:11 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Marcel Moolenaar Date: Mon, 13 Dec 2004 18:09:55 -0500 User-Agent: KMail/1.6.2 References: <200412130049.iBD0nq8o095802@repoman.freebsd.org> In-Reply-To: <200412130049.iBD0nq8o095802@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200412131809.55580.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2004 06:11:17 -0000 On Sunday 12 December 2004 07:49 pm, Marcel Moolenaar wrote: > marcel 2004-12-13 00:49:52 UTC > > FreeBSD src repository > > Modified files: > . Makefile > Log: > Unbreak the MAKEOBJDIRPREFIX variable check by avoiding bugs in make(1). > When make flags are passed to make in the environment, the string is > chopped up in an (argc,argv) vector. This happens in brk_string() and > the chopped up string is stored in static buffer. When this includes > something like "-V BINMAKE", then a pointer into the static buffer is > put on the variables list for evaluation later. However, brk_string() > is used for more than just chopping up the MAKEFLAGS env. variable, so > it's very likely that the static buffer is clobbered. In fact, this is > exactly what happens. > The result is that _MAKEOBJDIRPREFIX gets assigned whatever garbage > the child make happens to emit, causing the test to fail. Like this: > > pluto2% cd /usr/src > pluto2% make -V BINMAKE > "/q/6.x/src/Makefile", line 94: MAKEOBJDIRPREFIX can only be set in > environment, not as a global (in /etc/make.conf) or command-line variable. > pluto2% make -dv -V BINMAKE | & grep _MAKEOBJDIRPREFIX > Global:_MAKEOBJDIRPREFIX = } > > The fix is to not use MAKEFLAGS for this, but simple pass the flags > as arguments. Ideally make(1) should be fixed but that's beyond the > scope of my attention span. > > This fixes release. Thanks! This should also fix anyone upgrading their sparc to 64-bit time_t using the installworld_newk script. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org