From owner-cvs-all  Wed Oct 31 23:59: 1 2001
Delivered-To: cvs-all@freebsd.org
Received: from freebsd.dk (fw-rl0.freebsd.dk [212.242.86.114])
	by hub.freebsd.org (Postfix) with ESMTP
	id A7BDA37B403; Wed, 31 Oct 2001 23:58:56 -0800 (PST)
Received: (from sos@localhost)
	by freebsd.dk (8.11.6/8.11.3) id fA17wtx21551;
	Thu, 1 Nov 2001 08:58:55 +0100 (CET)
	(envelope-from sos)
From: Søren Schmidt <sos@freebsd.dk>
Message-Id: <200111010758.fA17wtx21551@freebsd.dk>
Subject: Re: cvs commit: src/sys/dev/ata ata-pci.c
In-Reply-To: <200111010521.fA15LoT74650@freefall.freebsd.org>
To: "Andrey A. Chernov" <ache@FreeBSD.org>
Date: Thu, 1 Nov 2001 08:58:55 +0100 (CET)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Reply-To: sos@freebsd.dk
X-Mailer: ELM [version 2.4ME+ PL94b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

It seems Andrey A. Chernov wrote:
> ache        2001/10/31 21:21:50 PST
> 
>   Modified files:
>     sys/dev/ata          ata-pci.c 
>   Log:
>   Use devclass_find_free_unit() in ata_pci_add_child() because no more
>   implicit auto-scanning up present in device_add_child(). Functionally it is
>   fully equivalent to old code.

What happend with having things reviewed by the maintainer ?

I havn't looked at this, but are you sure it handles the case where
the onboard controllers come _after_ the PCI bus is scanned, the
controller that is a MASTER_DEV _must_ end up as ata0/1.

-Søren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message