From owner-freebsd-current@FreeBSD.ORG  Sat Apr 23 03:37:39 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F70B16A4CE
	for <freebsd-current@freebsd.org>;
	Sat, 23 Apr 2005 03:37:39 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3314243D54; Sat, 23 Apr 2005 03:37:39 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3N3baAr034032;
	Sat, 23 Apr 2005 03:37:37 GMT
	(envelope-from davidxu@freebsd.org)
Message-ID: <4269C309.30702@freebsd.org>
Date: Sat, 23 Apr 2005 11:37:45 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.7.5) Gecko/20050402
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Doug White <dwhite@gumbysoft.com>
References: <1114052573.1075.10.camel@dirk.no.domain>
	<42678DC4.40309@freebsd.org> <20050422200102.G10333@carver.gumbysoft.com>
In-Reply-To: <20050422200102.G10333@carver.gumbysoft.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-current@freebsd.org
cc: Sam Lawrance <boris@brooknet.com.au>
Subject: Re: kern/78474 for 5.4? (kernel stack swapout problem again)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Apr 2005 03:37:39 -0000

Doug White wrote:

>On Thu, 21 Apr 2005, David Xu wrote:
>
>  
>
>>Sam Lawrance wrote:
>>
>>    
>>
>>>Will this problem:
>>>
>>>Swapped out procs not brought in immediately after child exits
>>>http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/78474
>>>
>>>be dealt with for the release of 5.4?
>>>
>>>Perhaps I'm the only FreeBSD user with swapped out processes ;-)
>>>
>>>-Sam
>>>
>>>
>>>
>>>
>>>      
>>>
>>I have noticed that current spinlock implementation no longer means that
>>CPU must be in critical region (critical_enter is called), even previous
>>hack TDP_WAKEPROC0 is no longer correct, :(, I think it is the time to
>>disable swapout.
>>    
>>
>
>I'm sorry, I can't parse your double negative.  On -CURRENT critical
>sections (entered with critical_enter()) no longer disable interrupts, but
>do inhibit preemption.  But spinlocks still do critical_enter() (see
>spinlock_enter()).
>
>  
>
I will commit the patch provided in the PR, it should work. I am just 
worrying
TDP_WAKEPROC0 will not work if spinlock does not entering critical region.