From owner-cvs-all Thu Nov 1 0:12:56 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 64E5437B407; Thu, 1 Nov 2001 00:12:45 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id fA18CcH66628; Thu, 1 Nov 2001 11:12:38 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2001 11:12:37 +0300 From: "Andrey A. Chernov" To: =?koi8-r?Q?S=F8ren?= Schmidt Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-pci.c Message-ID: <20011101111236.A66386@nagual.pp.ru> References: <200111010521.fA15LoT74650@freefall.freebsd.org> <200111010758.fA17wtx21551@freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200111010758.fA17wtx21551@freebsd.dk> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Nov 01, 2001 at 08:58:55 +0100, Søren Schmidt wrote: > It seems Andrey A. Chernov wrote: > > ache 2001/10/31 21:21:50 PST > > > > Modified files: > > sys/dev/ata ata-pci.c > > Log: > > Use devclass_find_free_unit() in ata_pci_add_child() because no more > > implicit auto-scanning up present in device_add_child(). Functionally it is > > fully equivalent to old code. > > What happend with having things reviewed by the maintainer ? There is absolutely no change at this place comparing to original variant of ATA code, so this change is outside one and needed because of duplicating devices handling code changed, to finish it, because there is no reports of this place abuse in other drivers. > I havn't looked at this, but are you sure it handles the case where > the onboard controllers come _after_ the PCI bus is scanned, the > controller that is a MASTER_DEV _must_ end up as ata0/1. I just functionally restore what was at this place before, based on N. Dudorov posted patch showing the bug place. I not touch ATA_MASTERDEV part of this function and don't know what happens there. The idea behind of interface change is: if you want automatic find of free slot, specify this action in a visible way, not using some bad internal magic of devclass_alloc_unit(). -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message