From owner-freebsd-arch@FreeBSD.ORG  Tue Sep  4 13:31:36 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D4FA21065674
	for <arch@freebsd.org>; Tue,  4 Sep 2012 13:31:36 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com
	[209.85.223.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 935478FC0C
	for <arch@freebsd.org>; Tue,  4 Sep 2012 13:31:36 +0000 (UTC)
Received: by iebc12 with SMTP id c12so6068072ieb.13
	for <arch@freebsd.org>; Tue, 04 Sep 2012 06:31:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=iBduvwPO8fme3RDk89iS6ctVIzMvcInQZi/2FDEFf7s=;
	b=SYBhH2bcsNrfPr6Yp0AwniCAgB9IoHOtbpUoywrR74qo+6aX9AyfrBDu8Ko+H2V/VV
	EU+A9OSGu3AxElegVdbUWwA2MTKiD9xMIbXl/a84acJGh3EWlSuB7neoy7wHPQXC/QlK
	+vLGXlqM2icqVLaHkKu8yRbJv3Ou+71CpL14ygUemC6o6wt2SMCzHgOxC7XWuU4rcXUG
	OvZtVVIN5D5NFUjK/1fuBu5M/vpkC4zFUr16dzbHCB8j/uS8A0EXi5oi72XUK7X3Bpxm
	honjC7wWzP+F1TBR03tJqhhiyUZvcjXDaTBC28+xFb8jO544CcX4vQiZgMF4y+CKUnsc
	hLVw==
Received: by 10.50.188.130 with SMTP id ga2mr14001938igc.32.1346765495970;
	Tue, 04 Sep 2012 06:31:35 -0700 (PDT)
Received: from 63.imp.bsdimp.com
	(50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198])
	by mx.google.com with ESMTPS id i17sm12334043igd.5.2012.09.04.06.31.34
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 04 Sep 2012 06:31:34 -0700 (PDT)
Sender: Warner Losh <wlosh@bsdimp.com>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <A4D4F17C-59C1-4DD0-94D0-AED021E265E8@freebsd.org>
Date: Tue, 4 Sep 2012 07:31:33 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <C7774C42-535E-4D35-9EE5-47344E46F315@bsdimp.com>
References: <A4D4F17C-59C1-4DD0-94D0-AED021E265E8@freebsd.org>
To: Oleksandr Tymoshenko <gonzo@freebsd.org>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQn+HiUuP2rMNya+5MYZEFmciHeYB1tdUTd2kjoI+bZ2QG2t/EA7i68Sdk20slHxOyxZ1AJR
Cc: "arch@freebsd.org" <arch@freebsd.org>, mav@freebsd.org
Subject: Re: [RFC] SDHCI driver split
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2012 13:31:36 -0000


On Sep 3, 2012, at 10:03 PM, Oleksandr Tymoshenko wrote:

> Hello,
> 
> Proposed patch[1] splits sdhci driver in two parts: reusable SDHCI 
> logic and PCI driver that provides access to registers. 
> 
> I tested it on X220 with Ricoh controller - no performance regression:
> reading 4Gb card takes 180 seconds (+/- 2) for both versions, old and new. 
> 
> If there are no objections - I'll commit it later this week. 
> 
> [1] http://people.freebsd.org/~gonzo/patches/sdhci-pci-3.diff

I don't see anything overtly broken in this patch.

Warner