From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Mar 23 17:30:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EE146BD6 for ; Sun, 23 Mar 2014 17:30:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CAA37FB2 for ; Sun, 23 Mar 2014 17:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2NHU0UQ057139 for ; Sun, 23 Mar 2014 17:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2NHU0Ur057138; Sun, 23 Mar 2014 17:30:00 GMT (envelope-from gnats) Resent-Date: Sun, 23 Mar 2014 17:30:00 GMT Resent-Message-Id: <201403231730.s2NHU0Ur057138@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jonathan Price Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B24049DB for ; Sun, 23 Mar 2014 17:20:53 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8477BEFA for ; Sun, 23 Mar 2014 17:20:53 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s2NHKrjH045321 for ; Sun, 23 Mar 2014 17:20:53 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s2NHKrL5045317; Sun, 23 Mar 2014 17:20:53 GMT (envelope-from nobody) Message-Id: <201403231720.s2NHKrL5045317@cgiserv.freebsd.org> Date: Sun, 23 Mar 2014 17:20:53 GMT From: Jonathan Price To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/187855: [PATCH] games/xonotic: add new optional dependency X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Mar 2014 17:30:01 -0000 >Number: 187855 >Category: ports >Synopsis: [PATCH] games/xonotic: add new optional dependency >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Mar 23 17:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jonathan Price >Release: 10.0-RELEASE >Organization: >Environment: FreeBSD bravo.pricetx.org 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: I have modified the games/xonotic port to add optional support for encryption using security/d0_blind_id. This encryption library is used by Xonotic by both the server and client to submit weapon and player statistics, as well as to optionally encrypt the traffic between the client and the server. Being that this provides statistics to the Xonotic community I have enabled this new optional dependency by default. However, as it is a cryptographic library, I am unsure whether this is suitable for certain countries (I know there are some restrictions on cryptography in the US etc). If somebody feels that this option should be disabled by default, then by all means do so. I contacted the port maintainer about this potential modification to the port over a week ago, and have not heard back from them sadly. However, you may want to CC them on this PR nonetheless. The diff has a .txt extension appended to allow it to be uploaded via firefox. >How-To-Repeat: >Fix: Patch attached with submission follows: --- Makefile.orig 2014-03-23 17:02:43.944551242 +0000 +++ Makefile 2014-03-23 17:04:29.765544110 +0000 @@ -3,7 +3,7 @@ PORTNAME= xonotic PORTVERSION= 0.7.0 -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= games MASTER_SITES= http://nl.dl.xonotic.org/ \ http://mirror.bitmissile.com/xonotic/releases/ @@ -32,17 +32,20 @@ PORTDATA= * OPTIONS_MULTI= COMPONENTS -OPTIONS_MULTI_COMPONENTS=CLIENT DEDICATED -OPTIONS_DEFAULT=CLIENT DEDICATED +OPTIONS_MULTI_COMPONENTS=CLIENT DEDICATED ENCRYPTION +OPTIONS_DEFAULT=CLIENT DEDICATED ENCRYPTION CLIENT_DESC= Build client DEDICATED_DESC= Build dedicated server +ENCRYPTION_DESC=Build encryption (required for stats submission) CLIENT_LIB_DEPENDS+= libmodplug.so:${PORTSDIR}/audio/libmodplug \ libtheora.so:${PORTSDIR}/multimedia/libtheora \ libvorbis.so:${PORTSDIR}/audio/libvorbis \ libogg.so:${PORTSDIR}/audio/libogg +ENCRYPTION_LIB_DEPENDS= libd0_rijndael.so:${PORTSDIR}/security/d0_blind_id + .include .if ${PORT_OPTIONS:MCLIENT} @@ -84,6 +87,9 @@ ${FIND} ${STAGEDIR}${DATADIR}/server -type f -name *.sh -o -name rcon*.pl | \ ${XARGS} ${CHMOD} +x .endif +.if ${PORT_OPTIONS:MENCRYPTION} + ${INSTALL_DATA} ${WRKDIR}/Xonotic/key_0.d0pk ${STAGEDIR}${PREFIX}/share/${PORTNAME} +.endif ${MKDIR} ${STAGEDIR}${DATADIR}/data ${INSTALL_DATA} ${WRKDIR}/Xonotic/data/*.pk3 ${STAGEDIR}${DATADIR}/data/ >Release-Note: >Audit-Trail: >Unformatted: