From owner-svn-src-head@freebsd.org  Fri Aug 28 07:30:31 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDBA99C4835;
 Fri, 28 Aug 2015 07:30:31 +0000 (UTC)
 (envelope-from darius@dons.net.au)
Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net
 [150.101.137.131])
 by mx1.freebsd.org (Postfix) with ESMTP id 97FB16B7;
 Fri, 28 Aug 2015 07:30:30 +0000 (UTC)
 (envelope-from darius@dons.net.au)
Received: from ppp118-210-47-210.lns20.adl2.internode.on.net (HELO
 midget.dons.net.au) ([118.210.47.210])
 by ipmail07.adl2.internode.on.net with ESMTP; 28 Aug 2015 16:55:17 +0930
Received: from macbook-pro.dons.net.au (MacBook-Pro.dons.net.au [10.0.2.26])
 (authenticated bits=0)
 by midget.dons.net.au (8.15.1/8.14.9) with ESMTPSA id t7S7Ow4T079038
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Fri, 28 Aug 2015 16:55:03 +0930 (CST)
 (envelope-from darius@dons.net.au)
Subject: Re: svn commit: r287236 - head/bin/df
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Content-Type: text/plain; charset=us-ascii
From: "O'Connor, Daniel" <darius@dons.net.au>
In-Reply-To: <20150828060458.GA20642@FreeBSD.org>
Date: Fri, 28 Aug 2015 16:54:58 +0930
Cc: NGie Cooper <yaneurabeya@gmail.com>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Xin LI <delphij@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au>
References: <201508280044.t7S0ixfW038766@repo.freebsd.org>
 <20150828044312.GA88538@FreeBSD.org>
 <CAGHfRMDw0=-ze4cd7mAoHO_n+t8NdYsR0On2YE5=s_gQ4=xveg@mail.gmail.com>
 <20150828060458.GA20642@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
X-Mailer: Apple Mail (2.2104)
X-Spam-Score: -4.238 () ALL_TRUSTED,BAYES_00,RP_MATCHES_RCVD
X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2015 07:30:31 -0000


> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote:
>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <danfe@freebsd.org> =
wrote:
>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote:
>>>> New Revision: 287236
>>>> URL: https://svnweb.freebsd.org/changeset/base/287236
>>>>=20
>>>> Log:
>>>>  Use exit() instead of return in main().
>>>=20
>>> Because?..
>>=20
>> Probably because of libxo...
>=20
> I'm just wondering how hard is it to write sensible commit logs. :(

To put it in a hopefully more helpful way..
Please write why your change is doing something, not what it is doing.

Saying what it is doing is OK if it's really hairy, but 99% of the time =
that isn't the case.

Assuming this is a libxo thing the commit log should have been something =
like..
"Use exit out of main otherwise libxo will not flush properly"
(or something similar)

Although it would be surprising if libxo required you to use exit()..

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C