From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Mar 23 18:00:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B84F063D for ; Sun, 23 Mar 2014 18:00:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 927B4298 for ; Sun, 23 Mar 2014 18:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2NI00tf066217 for ; Sun, 23 Mar 2014 18:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2NI00mg066216; Sun, 23 Mar 2014 18:00:00 GMT (envelope-from gnats) Resent-Date: Sun, 23 Mar 2014 18:00:00 GMT Resent-Message-Id: <201403231800.s2NI00mg066216@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Raphael Kubo da Costa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 59A64474; Sun, 23 Mar 2014 17:53:10 +0000 (UTC) Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com [IPv6:2a00:1450:4010:c04::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AB47924C; Sun, 23 Mar 2014 17:53:09 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id n15so3026195lbi.13 for ; Sun, 23 Mar 2014 10:53:07 -0700 (PDT) Received: from localhost (a91-154-115-217.elisa-laajakaista.fi. [91.154.115.217]) by mx.google.com with ESMTPSA id u4sm11144653laj.2.2014.03.23.10.53.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Mar 2014 10:53:07 -0700 (PDT) Message-Id: <532f1f83.0425980a.575f.ffffdd3a@mx.google.com> Date: Sun, 23 Mar 2014 10:53:07 -0700 (PDT) From: Raphael Kubo da Costa Sender: Raphael Kubo da Costa To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/187857: [PATCH] multimedia/vlc: Stop depending on bitstream-vera, add explicit fontconfig/freetype dependencies Cc: multimedia@FreeBSD.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Mar 2014 18:00:00 -0000 >Number: 187857 >Category: ports >Synopsis: [PATCH] multimedia/vlc: Stop depending on bitstream-vera, add explicit fontconfig/freetype dependencies >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Mar 23 18:00:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Raphael Kubo da Costa >Release: FreeBSD 11.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD orwell 11.0-CURRENT FreeBSD 11.0-CURRENT #8 r263206: Sat Mar 15 19:30:03 EET >Description: This patch contains two separate changes related to VLC's font rendering settings. 1. Remove the WITH_VLC_DEFAULT_FONT variable and its accompanying sed call. For one, the Bitstream Vera family has long been deprecated in favour of the Dejavu fonts. Additionally, these settings are simply not used at all, since if Fontconfig support is detected VLC will refer to font family names instead of file paths in the system. 2. While here, make it explicit that VLC depends on Fontconfig and Freetype2. VLC's existing dependencies always bring those two libraries anyway, but it never hurts to be formally depend on them. Port maintainer (multimedia@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 1.00.2014.03.16 (mode: change, diff: SVN) >How-To-Repeat: >Fix: --- vlc-2.1.2.patch begins here --- Index: Makefile =================================================================== --- Makefile (revision 348876) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= vlc DISTVERSION= 2.1.2 -PORTREVISION= 3 +PORTREVISION= 4 PORTEPOCH= 4 CATEGORIES= multimedia audio ipv6 net www MASTER_SITES= http://download.videolan.org/pub/videolan/${PORTNAME}/${DISTVERSION:S/a$//}/ \ @@ -17,7 +17,9 @@ LIB_DEPENDS= libgcrypt.so:${PORTSDIR}/security/libgcrypt \ libproxy.so:${PORTSDIR}/net/libproxy \ - libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi + libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi \ + libfontconfig.so:${PORTSDIR}/x11-fonts/fontconfig \ + libfreetype.so:${PORTSDIR}/print/freetype2 BUILD_DEPENDS= ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg RUN_DEPENDS= ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg @@ -404,13 +406,6 @@ WITH_DVD_DEVICE?=/dev/acd0 .endif -# If you change this value, the dependency will not be recorded -.if !defined(WITH_VLC_DEFAULT_FONT) -WITH_VLC_DEFAULT_FONT= ${LOCALBASE}/lib/X11/fonts/bitstream-vera/Vera.ttf -WITH_VLC_DEFAULT_MONO_FONT= ${LOCALBASE}/lib/X11/fonts/bitstream-vera/VeraMono.ttf -RUN_DEPENDS+= ${LOCALBASE}/lib/X11/fonts/bitstream-vera/Vera.ttf:${PORTSDIR}/x11-fonts/bitstream-vera -.endif - post-patch: @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \ -e '\|LIBS|s|-lrt||' \ @@ -419,8 +414,6 @@ @${REINPLACE_CMD} -e 's|^pkgconfigdir.*|pkgconfigdir = \$$\(prefix\)/libdata/pkgconfig|' \ ${WRKSRC}/src/Makefile.in \ ${WRKSRC}/lib/Makefile.in - @${REINPLACE_CMD} -e 's|/usr/share/fonts/truetype/freefont/FreeSerifBold.ttf|${WITH_VLC_DEFAULT_FONT}|' \ - ${WRKSRC}/modules/text_renderer/freetype.c @${REINPLACE_CMD} -e 's|/dev/cdrom|${WITH_CDROM_DEVICE}|g' \ -e 's|/dev/dvd|${WITH_DVD_DEVICE}|g' \ ${WRKSRC}/include/vlc_config.h --- vlc-2.1.2.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: