From owner-freebsd-ports@FreeBSD.ORG Tue May 13 16:24:23 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5BC0336B for ; Tue, 13 May 2014 16:24:23 +0000 (UTC) Received: from eu1sys200aog121.obsmtp.com (eu1sys200aog121.obsmtp.com [207.126.144.151]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A876426F4 for ; Tue, 13 May 2014 16:24:22 +0000 (UTC) Received: from mail-we0-f178.google.com ([74.125.82.178]) (using TLSv1) by eu1sys200aob121.postini.com ([207.126.147.11]) with SMTP ID DSNKU3JHNHfCs6H49KYg2R+Npfdz1yofgvNe@postini.com; Tue, 13 May 2014 16:24:22 UTC Received: by mail-we0-f178.google.com with SMTP id u56so629226wes.37 for ; Tue, 13 May 2014 09:24:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:message-id:to:subject:reply-to :in-reply-to; bh=MHniWPY+WvaLXJVKbXw26DMsK6zER3NLaH41Vm0OdCc=; b=XhM48YUDc6+Wp7IkGmNZjbaXDCuKN9rHJo2eIW6z5ZZDdMbIQFtQpSpu+YOQql1F1O kKUF/JBYsU5xT6pR7iKbI9jY2rbOvTHthaVmKg1DaFxg5t/n0ODEUVQA/CFktSHYA2nn /Ne0K/RVEZ+LBxu4lPCmb0f9kIrx0WNSx2bFtKl0kx7SHvlsB7V9mmgCLFwQ7r79HOMj BeRpttMV4tG8JX5PqYE6bZUZ4Hqhsn8EbI33pqXdr8V00RSoRnMSZEwMmsYCOHg06o09 VBtPMADBTSed+YCkUfJ88OefeG9WCqlsIommUdTz6ZX6/Yrx5Aqb2uh+62c7WseesJ04 gKkQ== X-Received: by 10.180.7.198 with SMTP id l6mr21804300wia.52.1399997888497; Tue, 13 May 2014 09:18:08 -0700 (PDT) X-Gm-Message-State: ALoCoQmB/GUAcU+VH7eSCjC+TdMHMyX4ouf1UhB+l9LKZ/Mc29LHQA+bLZRfYnXXh9vT6nEzNdnFEPBjtgYMcb4hln1vSVk6EwaAGTNCbcr1Z+52+ZY9E7ZsKI+8SCpvY+RyXGJ2df8hm7ScfR5eQxFeGqc/M2kD/w== X-Received: by 10.180.7.198 with SMTP id l6mr21804283wia.52.1399997888345; Tue, 13 May 2014 09:18:08 -0700 (PDT) Received: from mech-cluster241.men.bris.ac.uk (mech-cluster241.men.bris.ac.uk. [137.222.187.241]) by mx.google.com with ESMTPSA id k19sm22695977wic.10.2014.05.13.09.18.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 May 2014 09:18:07 -0700 (PDT) Sender: Anton Shterenlikht Received: from mech-cluster241.men.bris.ac.uk (localhost [127.0.0.1]) by mech-cluster241.men.bris.ac.uk (8.14.8/8.14.8) with ESMTP id s4DGI63F001386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 13 May 2014 17:18:06 +0100 (BST) (envelope-from mexas@mech-cluster241.men.bris.ac.uk) Received: (from mexas@localhost) by mech-cluster241.men.bris.ac.uk (8.14.8/8.14.8/Submit) id s4DGI6Yr001385; Tue, 13 May 2014 17:18:06 +0100 (BST) (envelope-from mexas) Date: Tue, 13 May 2014 17:18:06 +0100 (BST) From: Anton Shterenlikht Message-Id: <201405131618.s4DGI6Yr001385@mech-cluster241.men.bris.ac.uk> To: freebsd-ports@freebsd.org, matthew@FreeBSD.org Subject: Re: make check-plist ok, but portlint complains: %%PORTDOCS%%@dirrm %%DOCSDIR%% missing Reply-To: mexas@bris.ac.uk In-Reply-To: <5371154F.2060600@FreeBSD.org> X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2014 16:24:23 -0000 >On 12/05/2014 18:36, Anton Shterenlikht wrote: >> I'm updating devel/robodoc to staging. >> As suggested on the wiki page, >> env DEVELOPER=3Dyes make stage && make check-plist && make package >> runs fine, no issues. >> However, portlint -A reports: >>=20 >> # portlint -A >> WARN: /usr/ports/devel/robodoc/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%D= >OCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true''= > are missing. At least one should be used. >>=20 >> I have in pkg-plist: >>=20 >> bin/robodoc >> bin/robohdrs >> man/man1/robodoc.1.gz >> man/man1/robohdrs.1.gz >> %%DOCSDIR%%/AUTHORS >> %%DOCSDIR%%/ChangeLog >> %%DOCSDIR%%/NEWS >> %%DOCSDIR%%/README >> %%DOCSDIR%%/manual.css >> %%DOCSDIR%%/manual.html >> %%DOCSDIR%%/robodoc_example.rc >> %%EXAMPLESDIR%%/PerlExample/Source/Box.pm >> %%EXAMPLESDIR%%/PerlExample/Source/Box/RectangularBox.pm >> %%EXAMPLESDIR%%/PerlExample/Source/Box/SquareBox.pm >> %%EXAMPLESDIR%%/PerlExample/Source/Cargo.txt >> %%EXAMPLESDIR%%/PerlExample/Source/Loader.txt >> %%EXAMPLESDIR%%/PerlExample/Source/SmartLoader.pm >> %%EXAMPLESDIR%%/PerlExample/Source/TruckPacker.pl >> %%EXAMPLESDIR%%/PerlExample/robodoc.rc >> @dirrmtry %%DOCSDIR%% >> @dirrmtry %%EXAMPLESDIR%%/PerlExample/Source/Box >> @dirrmtry %%EXAMPLESDIR%%/PerlExample/Source >> @dirrmtry %%EXAMPLESDIR%%/PerlExample >> @dirrmtry %%EXAMPLESDIR%% >>=20 >> What's the problem? >>=20 >> As recommended on the wiki page I made >> the docs and examples non-optional, because >> they are very small. > >portlint results are guidelines: if there's a good reason to do things >in a way that portlint complains about, then go right ahead. However, >you may have to justify your choices and persuade a committer to commit >as is. > >Given you're installing some docs and examples, I'd add support for >making them optional, even if they are pretty neglible in size. It's >probably better for your port to behave in-line with other ports even if >not doing that is a reasonable choice. > >Enabling DOCS and EXAMPLES in your port is pretty simple. You need to >add %%PORTDOCS%% and %%PORTEXAMPLES%% to the appropriate lines in >pkg-plist and add > >OPTIONS_DEFINE+=3D DOCS EXAMPLES > >to the Makefile if you want them to show up in an options dialogue. still the same: # cat pkg-plist bin/robodoc bin/robohdrs man/man1/robodoc.1.gz man/man1/robohdrs.1.gz %%PORTDOCS%%%%DOCSDIR%%/AUTHORS %%PORTDOCS%%%%DOCSDIR%%/ChangeLog %%PORTDOCS%%%%DOCSDIR%%/NEWS %%PORTDOCS%%%%DOCSDIR%%/README %%PORTDOCS%%%%DOCSDIR%%/manual.css %%PORTDOCS%%%%DOCSDIR%%/manual.html %%PORTDOCS%%%%DOCSDIR%%/robodoc_example.rc %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/Box.pm %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/Box/RectangularBox.pm %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/Box/SquareBox.pm %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/Cargo.txt %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/Loader.txt %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/SmartLoader.pm %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/Source/TruckPacker.pl %%PORTEXAMPLES%%%%EXAMPLESDIR%%/PerlExample/robodoc.rc %%PORTDOCS%%@dirrmtry %%DOCSDIR%% %%PORTEXAMPLES%%@dirrmtry %%EXAMPLESDIR%%/PerlExample/Source/Box %%PORTEXAMPLES%%@dirrmtry %%EXAMPLESDIR%%/PerlExample/Source %%PORTEXAMPLES%%@dirrmtry %%EXAMPLESDIR%%/PerlExample %%PORTEXAMPLES%%@dirrmtry %%EXAMPLESDIR%% # # portlint -A WARN: /usr/ports/devel/robodoc/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should be used. I guess the issue is about dirrm vs dirrmtry ? Thanks Anton