From owner-cvs-all  Wed Apr 25 23:13:27 2001
Delivered-To: cvs-all@freebsd.org
Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id 58F8E37B423; Wed, 25 Apr 2001 23:13:17 -0700 (PDT)
	(envelope-from mark@grondar.za)
Received: from grondar.za (gratis.grondar.za [196.7.18.133])
	by gratis.grondar.za (8.11.3/8.11.3) with ESMTP id f3Q6Ciw85147;
	Thu, 26 Apr 2001 08:12:57 +0200 (SAST)
	(envelope-from mark@grondar.za)
Message-Id: <200104260612.f3Q6Ciw85147@gratis.grondar.za>
To: Bruce Evans <bde@zeta.org.au>
Cc: Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/make Makefile 
References: <Pine.BSF.4.21.0104260928090.27646-100000@besplex.bde.org> 
In-Reply-To: <Pine.BSF.4.21.0104260928090.27646-100000@besplex.bde.org> ; from Bruce Evans <bde@zeta.org.au>  "Thu, 26 Apr 2001 09:29:45 +1000."
Date: Thu, 26 Apr 2001 08:14:24 +0200
From: Mark Murray <mark@grondar.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> On Wed, 25 Apr 2001, Ruslan Ermilov wrote:
> 
> > ru          2001/04/25 07:59:16 PDT
> > 
> >   Modified files:
> >     usr.bin/make         Makefile 
> >   Log:
> >   Add -Wall.
> 
> Please don't clutter individual Makefiles with unportable flags that should
> be global anyway.  CFLAGS+=-Wall breaks compiling with non-gcc compilers...

More importantly - flags that aren't -DBLAH or -I/path break lint(1).

M
-- 
Mark Murray
Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message