From owner-freebsd-bugs@FreeBSD.ORG  Wed Jun 29 16:50:07 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0FCA41065670
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 29 Jun 2011 16:50:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id EFC7B8FC0A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 29 Jun 2011 16:50:06 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5TGo6ia016585
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 29 Jun 2011 16:50:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5TGo6S4016584;
	Wed, 29 Jun 2011 16:50:06 GMT (envelope-from gnats)
Date: Wed, 29 Jun 2011 16:50:06 GMT
Message-Id: <201106291650.p5TGo6S4016584@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/157732: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2011 16:50:07 -0000

The following reply was made to PR bin/157732; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/157732: commit references a PR
Date: Wed, 29 Jun 2011 16:44:04 +0000 (UTC)

 Author: dim
 Date: Wed Jun 29 16:43:44 2011
 New Revision: 223678
 URL: http://svn.freebsd.org/changeset/base/223678
 
 Log:
   MFC r223579:
   
   For some reason, contrib/traceroute/traceroute.c ensures MAXHOSTNAMELEN
   is defined, but then proceeds to use a hardcoded maximum hostname length
   of 64 anyway.  Fix this by checking against MAXHOSTNAMELEN instead.
   
   PR:	bin/157732
 
 Modified:
   stable/8/contrib/traceroute/traceroute.c
 Directory Properties:
   stable/8/contrib/traceroute/   (props changed)
 
 Modified: stable/8/contrib/traceroute/traceroute.c
 ==============================================================================
 --- stable/8/contrib/traceroute/traceroute.c	Wed Jun 29 16:40:41 2011	(r223677)
 +++ stable/8/contrib/traceroute/traceroute.c	Wed Jun 29 16:43:44 2011	(r223678)
 @@ -1625,7 +1625,7 @@ gethostinfo(register char *hostname)
  	register char **p;
  	register u_int32_t addr, *ap;
  
 -	if (strlen(hostname) > 64) {
 +	if (strlen(hostname) >= MAXHOSTNAMELEN) {
  		Fprintf(stderr, "%s: hostname \"%.32s...\" is too long\n",
  		    prog, hostname);
  		exit(1);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"