From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Feb 6 08:20:04 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7EAD246D for ; Wed, 6 Feb 2013 08:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 4DA1E73C for ; Wed, 6 Feb 2013 08:20:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r168K4cp073500 for ; Wed, 6 Feb 2013 08:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r168K4Q0073495; Wed, 6 Feb 2013 08:20:04 GMT (envelope-from gnats) Resent-Date: Wed, 6 Feb 2013 08:20:04 GMT Resent-Message-Id: <201302060820.r168K4Q0073495@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexey Markov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3C151D6B for ; Wed, 6 Feb 2013 08:14:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 1BCD96E8 for ; Wed, 6 Feb 2013 08:14:24 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r168ENcZ079659 for ; Wed, 6 Feb 2013 08:14:23 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r168EN3A079658; Wed, 6 Feb 2013 08:14:23 GMT (envelope-from nobody) Message-Id: <201302060814.r168EN3A079658@red.freebsd.org> Date: Wed, 6 Feb 2013 08:14:23 GMT From: Alexey Markov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/175877: www/calamaris warns about deprecated construction in the code X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2013 08:20:04 -0000 >Number: 175877 >Category: ports >Synopsis: www/calamaris warns about deprecated construction in the code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 06 08:20:03 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Alexey Markov >Release: 8.3-RELEASE-p3 >Organization: JSC Complitex >Environment: FreeBSD meson.complitex.ru 8.3-RELEASE-p5 FreeBSD 8.3-RELEASE-p5 #0: Fri Nov 23 12:41:36 MSK 2012 redrat@meson.complitex.ru:/arc/obj/arc/src/sys/MESON amd64 >Description: After upgrading Perl from 5.10 to 5.12 I have warnings on every run of calamaris: defined(%hash) is deprecated at /usr/local/bin/calamaris line 2609. (Maybe you should just omit the defined()?) It's pretty annoying if calamaris runs from cron job. After some research and googling I have find out that since Perl 5.12 'defined' must not be applied to the hashes and arrays. >How-To-Repeat: Install Calamaris and Perl 5.12 (or more recent) and run calamaris. >Fix: Apply the attached patch. Patch attached with submission follows: --- calamaris.orig 2013-02-05 11:25:07.000000000 +0400 +++ calamaris 2013-02-06 11:52:16.000000000 +0400 @@ -2606,7 +2606,7 @@ 100, 100 * $tcp_hit / $tcp ); } outstop(10); - if ( defined(%tcp_content) ) { + if ( %tcp_content ) { outstart(11); if ( $tcp == 0 ) { outline( 11, 'no matching requests' ); >Release-Note: >Audit-Trail: >Unformatted: