From owner-cvs-all Thu Nov 1 0:30: 6 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 9C6BD37B405; Thu, 1 Nov 2001 00:29:56 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id fA18TpR67069; Thu, 1 Nov 2001 11:29:51 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2001 11:29:49 +0300 From: "Andrey A. Chernov" To: =?koi8-r?Q?S=F8ren?= Schmidt Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-pci.c Message-ID: <20011101112948.C66386@nagual.pp.ru> References: <20011101111236.A66386@nagual.pp.ru> <200111010819.fA18Jku26675@freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200111010819.fA18Jku26675@freebsd.dk> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Nov 01, 2001 at 09:19:46 +0100, Søren Schmidt wrote: > > Uh, oh, how the MASTERDEV thing works is *vital* to this. I test whole kernel on my two ATA controllers with two devices on each one, and it works. I don't pretend that my fix is complete, just showing example way how such things must be done. Maybe MASTERDEV need be fixed too in the similar way, as with unit 2, I simple don't know. > > The idea behind of interface change is: if you want automatic find of free > > slot, specify this action in a visible way, not using some bad > > internal magic of devclass_alloc_unit(). > > That was exactly what I was afraid off, the reason the code used the > hard value '2', was that I dont care what number I get, but its *must* > be bigger than or equal to '2'. If this doesn't happen now, booting > on aforementioned boards are totally broken :( As I already say, currently new interface function return 2 or bigger number, if 2 is occupped. > *That* is why you should check with the maintainer before comitting :) Maybe you are right. I assume you read whole thread CC'ed to you why all of this happens, so there is no some surprize. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message