From owner-cvs-src@FreeBSD.ORG Fri Jun 15 20:50:33 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9272816A400; Fri, 15 Jun 2007 20:50:33 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) by mx1.freebsd.org (Postfix) with ESMTP id 5DFAF13C48A; Fri, 15 Jun 2007 20:50:33 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-6.cisco.com with ESMTP; 15 Jun 2007 13:50:33 -0700 X-IronPort-AV: i="4.16,426,1175497200"; d="scan'208"; a="166077814:sNHT49094199" Received: from sj-core-2.cisco.com (sj-core-2.cisco.com [171.71.177.254]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id l5FKoX82013732; Fri, 15 Jun 2007 13:50:33 -0700 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-2.cisco.com (8.12.10/8.12.6) with ESMTP id l5FKoWaI005250; Fri, 15 Jun 2007 20:50:33 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 15 Jun 2007 13:50:32 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 15 Jun 2007 13:50:32 -0700 Message-ID: <4672FC0B.1090907@cisco.com> Date: Fri, 15 Jun 2007 16:52:27 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200706142259.l5EMx4aW053356@repoman.freebsd.org> <20070615022956.GA96741@rot13.obsecurity.org> <4671FA96.1010304@cisco.com> <200706151340.29868.jhb@freebsd.org> In-Reply-To: <200706151340.29868.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 Jun 2007 20:50:32.0491 (UTC) FILETIME=[D0B247B0:01C7AF8E] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1168; t=1181940633; x=1182804633; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/netinet=20sctp.h=20sctp_asc onf.c=20sctp_asconf.h=0A=20sctp_bsd_addr.c=20sctp_constants.h=20sctp_indat a.c=20sctp_input.c=20sctp_lock_bsd.h=0A=20sctp_os_bsd.h=20sctp_output.c=20 sctp_pcb.c=20sctp_pcb.h=20sctp_peeloff.c=20sctp_sysctl.c=0A=20sctp_sysctl. h=20sctp_timer.c=20sctp_uio.h=20... |Sender:=20; bh=eJ7aLnIaTD8n+wUsV/C0sObru2Zejwi/4w5NZjBuKzo=; b=emWRztOXhMfxtyRe+j/SAZWenA7UGthGqS1nrxSEcbm+q1VlVipKE98Gys7NpIr9ClgROt7z CCF/3//9KhthofHMPxNjvD37m2sx1BvjifNSB4F5CoSnKIARnufVn+jT; Authentication-Results: sj-dkim-3; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim3002 verified; ); Cc: Randall Stewart , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Kris Kennaway Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_uio.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 20:50:33 -0000 John Baldwin wrote: > > Also, I would use KTR_SCTP and use the same #ifdef above so it is 0 or > KTR_SUBSYS depending on whether or not you want it enabled. > Changing the name around is cosmetic.. and no problem.. The actual ifdef with 0, though.. we have a seperate mask.. since there are 21 or so things that can be logged/traced and they all generate quite a bit of output.. which can be graphed and charted.. along with the usual debugging lot.. Thus there is a seperate mask that turns these on/off.. So .. if for instance you enable KTR_SUBSYS (aka KTR_SCTP) then nothing will come out until you enable the various logging levels in SCTP. The question of if an ifdef is needed.. I did a little performance study yesterday... since originally all the tracepoints were ifdef'd.. so I decided to see if there was any noticable performance penalty for having the additional if(logging mask) CTR6() and I could not measure the difference.. thus all but a few of the ifdef's around these (and thus the options in the build) came out.. R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)