From owner-cvs-ports@FreeBSD.ORG Sun Mar 21 09:01:32 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2C6A16A4CF; Sun, 21 Mar 2004 09:01:32 -0800 (PST) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68C5C43D2F; Sun, 21 Mar 2004 09:01:32 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i2LH1VUN007542; Sun, 21 Mar 2004 09:01:31 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i2LH1UPo007540; Sun, 21 Mar 2004 09:01:30 -0800 (PST) (envelope-from obrien) Date: Sun, 21 Mar 2004 09:01:30 -0800 From: "David O'Brien" To: Gerald Pfeifer Message-ID: <20040321170130.GB159@dragon.nuxi.com> References: <200403170818.i2H8IFYU008824@repoman.freebsd.org> <20040317112344.GB86662@dragon.nuxi.com> <20040317182432.GA96023@dragon.nuxi.com> <20040320195311.GB89343@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/gcc34 Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2004 17:01:33 -0000 On Sun, Mar 21, 2004 at 11:54:05AM +0100, Gerald Pfeifer wrote: > On Sat, 20 Mar 2004, David O'Brien wrote: > > Actually this is a bug in your pkg-plist. I just tested this with your > > latest commits (Makefile rev 1.166, pkg-plist rev 1.55). This patch > > (which I just committed) makes the existing breakage obvious: > > > > @dirrm libexec/gcc/%%GNU_HOST%%/%%GCC_VER%% > > +@dirrm libexec/gcc/%%GNU_HOST%% > > +@dirrm libexec/gcc > > %%LIBJAVA%%share/java/libgcj-%%GCC_VER%%.jar > > Won't this break if more than gcc3x port has been installed? Nope. When one 'pkg_delete' they'll just get a warning that the directory couldn't be removed. AFAIK that is the prefered behavior vs. potentially leaving behind an empty directory. > (I'll shortly mark them as CONFLICTing, but in the longer term this > should work.) IMHO, you should not -- GCC fully supports more than one version installed at the same time. > > Can we agree to this patch now? > > > > .if ${ARCH} == "amd64" > > CONFIGURE_TARGET= x86_64-portbld-freebsd${OSREL} > > -.else > > -CONFIGURE_TARGET= ${ARCH}-portbld-freebsd${OSREL} > > .endif > > Sure, iff it survives full testing (including a `make deinstall` that > really removes all files installed by the port). Grrr. you're putting a higher bar on this patch than you've put on your latest commits. The test should be no regression from the current state of the port after committing this diff. As I mentioned, the problem you claimed was caused by this patch existed before it. -- -- David (obrien@FreeBSD.org)