From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 25 15:10:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3BB416A421 for ; Thu, 25 Oct 2007 15:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B0A6013C4B5 for ; Thu, 25 Oct 2007 15:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9PFA22e042576 for ; Thu, 25 Oct 2007 15:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9PFA2sk042575; Thu, 25 Oct 2007 15:10:02 GMT (envelope-from gnats) Resent-Date: Thu, 25 Oct 2007 15:10:02 GMT Resent-Message-Id: <200710251510.l9PFA2sk042575@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pietro Cerutti Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EF1516A417 for ; Thu, 25 Oct 2007 15:07:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 1B98F13C4A3 for ; Thu, 25 Oct 2007 15:07:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9PF6stw029861 for ; Thu, 25 Oct 2007 15:06:54 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id l9PF6smx029860; Thu, 25 Oct 2007 15:06:54 GMT (envelope-from nobody) Message-Id: <200710251506.l9PF6smx029860@www.freebsd.org> Date: Thu, 25 Oct 2007 15:06:54 GMT From: Pietro Cerutti To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/117488: [patch] sysutils/screen enable installation of man page X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 15:10:02 -0000 >Number: 117488 >Category: ports >Synopsis: [patch] sysutils/screen enable installation of man page >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Oct 25 15:10:02 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Pietro Cerutti >Release: 6.2-STABLE >Organization: Bern University of Applied Sciences >Environment: FreeBSD gahrtop.localhost 6.2-STABLE FreeBSD 6.2-STABLE #3: Wed Oct 24 08:30:39 CEST 2007 root@gahrtop.localhost:/usr/obj/usr/src/sys/MSI1034 i386 >Description: sysutils/screen doesn't handle the MAN option correctly: the man page is never installed >How-To-Repeat: cd /usr/ports/sysutils/screen make WITH_MAN=yes install find /usr/local/man/man1/ -name "screen*" >Fix: Apply this patch to the port's Makefile. Note: a similar problem exists with the INFO option: the INFO doesn't get installed. I'm planning to solve that issue in a future PR, but since INFO pages seem to be much less used than MAN pages, I think this patch deserves higher attention. --- Makefile.orig 2007-10-25 17:00:50.000000000 +0200 +++ Makefile 2007-10-25 16:58:22.000000000 +0200 @@ -24,11 +24,6 @@ XTERM_256 "Enable support for 256 colour xterm" OFF GNU_CONFIGURE= yes -.if defined(WITH_MAN) -MAN1= screen.1 -.else -MAKE_ARGS+= -DNO_MAN -.endif .if defined(WITH_INFO) .if !exists(/usr/bin/install-info) RUN_DEPENDS+= install-info:${PORTSDIR}/print/texinfo @@ -42,6 +37,12 @@ .include +.if defined(WITH_MAN) +MAN1= screen.1 +.else +MAKE_ARGS+= -DNO_MAN +.endif + .if ${ARCH} == "alpha" CFLAGS+= -O0 .endif @@ -72,5 +73,8 @@ @if [ ! -f ${PREFIX}/etc/screenrc ]; then \ ${CP} ${EXAMPLESDIR}/screenrc ${PREFIX}/etc/screenrc ; \ fi +.if defined(WITH_MAN) + ${INSTALL_MAN} ${WRKSRC}/doc/screen.1 ${MANPREFIX}/man/man1 +.endif .include >Release-Note: >Audit-Trail: >Unformatted: >> no output <<