From owner-cvs-src@FreeBSD.ORG  Sat Apr  7 16:40:24 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 59FD716A401;
	Sat,  7 Apr 2007 16:40:24 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id CF99C13C4BC;
	Sat,  7 Apr 2007 16:40:23 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.8/8.13.8) with ESMTP id l37GeMWp010385;
	Sat, 7 Apr 2007 20:40:22 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.8/8.13.8/Submit) id l37GeMX8010384;
	Sat, 7 Apr 2007 20:40:22 +0400 (MSD) (envelope-from ache)
Date: Sat, 7 Apr 2007 20:40:22 +0400
From: Andrey Chernov <ache@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20070407164022.GA10309@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200704071602.l37G2V1c066806@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200704071602.l37G2V1c066806@repoman.freebsd.org>
User-Agent: Mutt/1.5.14 (2007-02-12)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include stdio.h src/sys/sys unistd.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2007 16:40:24 -0000

On Sat, Apr 07, 2007 at 04:02:31PM +0000, Pawel Jakub Dawidek wrote:
>   - Only define SEEK_DATA and SEEK_HOLE in sys/unistd.h when neither
>     _POSIX_SOURCE nor _XOPEN_SOURCE is defined.

1) This new addition should be exluded for !define(_C99_SOURCE)
!define(_ANSI_SOURCE) !define(_POSIX_C_SOURCE) too.

2) We design our *_VISIBLE framework right for the reason to not mention 
all possible *_SOURCE each time like this, making includes unnecessary big 
and hard to adapt to the future *_SOURCE tags, but mention one *_VISIBLE 
tag instead, so please rewrite this thing using it.

-- 
http://ache.pp.ru/