From owner-cvs-all Thu Nov 1 0:39: 7 2001 Delivered-To: cvs-all@freebsd.org Received: from freebsd.dk (fw-rl0.freebsd.dk [212.242.86.114]) by hub.freebsd.org (Postfix) with ESMTP id DE64437B401; Thu, 1 Nov 2001 00:39:01 -0800 (PST) Received: (from sos@localhost) by freebsd.dk (8.11.6/8.11.3) id fA18cvx31431; Thu, 1 Nov 2001 09:38:57 +0100 (CET) (envelope-from sos) From: Søren Schmidt Message-Id: <200111010838.fA18cvx31431@freebsd.dk> Subject: Re: cvs commit: src/sys/dev/ata ata-pci.c In-Reply-To: <20011101112948.C66386@nagual.pp.ru> To: "Andrey A. Chernov" Date: Thu, 1 Nov 2001 09:38:57 +0100 (CET) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Reply-To: sos@freebsd.dk X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It seems Andrey A. Chernov wrote: [ Charset KOI8-R unsupported, converting... ] > On Thu, Nov 01, 2001 at 09:19:46 +0100, S?ren Schmidt wrote: > > > > Uh, oh, how the MASTERDEV thing works is *vital* to this. > > I test whole kernel on my two ATA controllers with two devices on each > one, and it works. I don't pretend that my fix is complete, just showing > example way how such things must be done. Maybe MASTERDEV need be fixed > too in the similar way, as with unit 2, I simple don't know. Hmm, then maybe it would have been an idea to have *asked* for review yes ? > > > The idea behind of interface change is: if you want automatic find of free > > > slot, specify this action in a visible way, not using some bad > > > internal magic of devclass_alloc_unit(). > > > > That was exactly what I was afraid off, the reason the code used the > > hard value '2', was that I dont care what number I get, but its *must* > > be bigger than or equal to '2'. If this doesn't happen now, booting > > on aforementioned boards are totally broken :( > > As I already say, currently new interface function return 2 or bigger > number, if 2 is occupped. If thats the case things should be OK... > > *That* is why you should check with the maintainer before comitting :) > > Maybe you are right. I assume you read whole thread CC'ed to you why all > of this happens, so there is no some surprize. I did, but I didn't post a "go ahead commit" did I ? maybe thats because I wanted to make sure it worked first... -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message