From owner-freebsd-ports  Thu Feb  8 11:30:28 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from blizzard.sabbo.net (blizzard.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3D7BA37B67D; Thu,  8 Feb 2001 11:30:00 -0800 (PST)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f18JTk604341;
	Thu, 8 Feb 2001 21:29:52 +0200
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.2/8.11.2) with ESMTP id f18JTom12407;
	Thu, 8 Feb 2001 21:29:50 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3A82F3A7.9F7BB427@FreeBSD.org>
Date: Thu, 08 Feb 2001 21:29:43 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.76 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: ports@FreeBSD.org, asami@FreeBSD.org
Subject: Request for comment: bsd.port.mk and recent pthreads changes
Content-Type: multipart/mixed;
 boundary="------------8A6F32E137C9AD9126F0700B"
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

This is a multi-part message in MIME format.
--------------8A6F32E137C9AD9126F0700B
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit

Hi,

As you may know recent changes in the pthreads (depreciation of -pthread flag)
made necessary to ajust many ports from our ports collection. This change would
be conditional, as older versions of the FreeBSD still need this flag.
Therefore it would be nice to have some support for that from the bsd.port.mk,
because it's not very handy to put the same conditional in every single port
that use pthreads. With this message I'm attaching patch that represents my
vision of such support. I would like to hear comments on it and theoretically
get it (or something like it) committed in the nearest future.

Thanks!

-Maxim

--------------8A6F32E137C9AD9126F0700B
Content-Type: text/plain; charset=koi8-r;
 name="bsd.port.mk-pthread.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="bsd.port.mk-pthread.diff"

--- bsd.port.mk	2001/02/08 19:09:54	1.2
+++ bsd.port.mk	2001/02/08 19:15:50
@@ -948,6 +948,14 @@
 MAKEFILE?=		Makefile
 MAKE_ENV+=		PREFIX=${PREFIX} LOCALBASE=${LOCALBASE} X11BASE=${X11BASE} MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"
 
+.if ${OSVERSION} < 500000
+PTHREAD_CFLAGS=	-D_THREAD_SAFE
+PTHREAD_LIBS=		"-pthread"
+.else
+PTHREAD_CFLAGS=	""
+PTHREAD_LIBS=		"-lc_r"
+.endif
+
 .if exists(/usr/bin/fetch)
 # avoid -A for 2.2 -- it's not ported to that branch
 .if ${OSVERSION} < 300000

--------------8A6F32E137C9AD9126F0700B--



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message