From owner-cvs-src@FreeBSD.ORG Sat Apr 12 12:01:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCF6637B405; Sat, 12 Apr 2003 12:01:25 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CC0C43F75; Sat, 12 Apr 2003 12:01:24 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h3CJ1Cd0025541; Sat, 12 Apr 2003 21:01:22 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 12 Apr 2003 10:25:49 PDT." Date: Sat, 12 Apr 2003 21:01:12 +0200 Message-ID: <25540.1050174072@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2003 19:01:26 -0000 In message , Nate Lawson wri tes: >Uh, tell me who is going to call cam_periph_ioctl()? This is necessary >to allow camcontrol to get a passthrough device. All the other drivers >call it. > >What bothers me is that you don't pay attention to MAINTAINERS: >>CAM gibbs, >> ken Pre-commit review requested. send to scsi@freebsd.org > >I don't think you'd be happy if I picked a random, seemingly unused >function in geom and nuked it, apparently without understanding the >impact. Please be considerate of others. > >-Nate I'd appreciate you check your facts before you attack people in the future. While attacking on unproven assumptions is all the rage these days it is still rather embarrasing when people point out that you are wrong in all aspects of your attack: The ioctl function in scsi_da is not called, libcam opens /dev/xpt and uses an ioctl there to find the correct pass device. The call path to the function has been disabled for a period with not a single complaint that I have been able to discover. Second, I have discussed this particular change with ken@, who as you correctly point out is the maintainer, and he agreed that the function was unused. So I really don't know why or what compelled you to attack me here, whatever it was: please try to control it better in the future. Over and out... Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.