From owner-cvs-src@FreeBSD.ORG Fri Mar 28 21:55:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 016FD37B405 for ; Fri, 28 Mar 2003 21:55:39 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 2A25A43F3F for ; Fri, 28 Mar 2003 21:55:37 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 93455 invoked from network); 29 Mar 2003 05:55:35 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 29 Mar 2003 05:55:35 -0000 X-pair-Authenticated: 209.68.2.70 Date: Fri, 28 Mar 2003 23:52:08 -0600 (CST) From: Mike Silbersack To: Mike Silbersack In-Reply-To: <200303290548.h2T5ma5Q007596@repoman.freebsd.org> Message-ID: <20030328234910.N3026@odysseus.silby.com> References: <200303290548.h2T5ma5Q007596@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c src/sys/sys mbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2003 05:55:42 -0000 I took the "goal" parameter back out. The more I thought about it, I realized that it would only lead to confusion wrt the semantics of what would be considered a failure. Additionally, the host chain is unharmed if memory allocation fails; this allows m_defrag to be called on critical chains during a time of low memory without the concern of the chain being lost. Also, thanks to Bosko's patch to m_dup_pkthdr, I use m_getcl when needed. I'm going to beef up MBUF_FRAG_TEST so it can create chains busdma_load_mbuf cannot coalesce, then I'm going to go hunting for deviant network drivers. On Fri, 28 Mar 2003, Mike Silbersack wrote: > silby 2003/03/28 21:48:36 PST > > FreeBSD src repository > > Modified files: > sys/kern uipc_mbuf.c > sys/sys mbuf.h > Log: > Add the m_defrag routine, as discussed on committers@. This > incarnation should address the concerns of all in the discussion, > and keeps statistics which show how much it is used. > > MFC after: 2 weeks > > Revision Changes Path > 1.112 +83 -0 src/sys/kern/uipc_mbuf.c > 1.117 +1 -0 src/sys/sys/mbuf.h >