From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 10 11:00:01 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 29C0F381 for ; Wed, 10 Oct 2012 11:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id 009688FC14 for ; Wed, 10 Oct 2012 11:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9AB00fs053180 for ; Wed, 10 Oct 2012 11:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9AB007X053173; Wed, 10 Oct 2012 11:00:00 GMT (envelope-from gnats) Resent-Date: Wed, 10 Oct 2012 11:00:00 GMT Resent-Message-Id: <201210101100.q9AB007X053173@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Erik Cederstrand Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 47D96136 for ; Wed, 10 Oct 2012 10:50:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 17E758FC20 for ; Wed, 10 Oct 2012 10:50:28 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q9AAoRsD087428 for ; Wed, 10 Oct 2012 10:50:27 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q9AAoRbe087427; Wed, 10 Oct 2012 10:50:27 GMT (envelope-from nobody) Message-Id: <201210101050.q9AAoRbe087427@red.freebsd.org> Date: Wed, 10 Oct 2012 10:50:27 GMT From: Erik Cederstrand To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/172566: Fix analyzer warnings in /games X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2012 11:00:01 -0000 >Number: 172566 >Category: misc >Synopsis: Fix analyzer warnings in /games >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 10 11:00:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Erik Cederstrand >Release: CURRENT >Organization: >Environment: >Description: Fix 4 warnings in /games reported by Clang Static Analyzer: bcd and caesar are not installed SETGID (at least on my system). Remove the call to setgid() as it becomes redundant. In fortune, make sure a tail file is passed in the args if mandated in the logic. Bail if not. In random(6), fix a memory leak in randomize_fd() >How-To-Repeat: >Fix: Se attached patch Patch attached with submission follows: Index: head/games/random/randomize_fd.c =================================================================== --- head/games/random/randomize_fd.c (revision 241370) +++ head/games/random/randomize_fd.c (working copy) @@ -207,6 +207,7 @@ goto make_token; } + free(buf); for (i = numnode; i > 0; i--) { selected = random() % numnode; Index: head/games/fortune/fortune/fortune.c =================================================================== --- head/games/fortune/fortune/fortune.c (revision 241370) +++ head/games/fortune/fortune/fortune.c (working copy) @@ -576,6 +576,10 @@ if (*head == NULL) *head = *tail = fp; else if (fp->percent == NO_PROB) { + if (*tail == NULL) { + fprintf(stderr, "No tail file given\n"); + exit(1); + } (*tail)->next = fp; fp->prev = *tail; *tail = fp; Index: head/games/bcd/bcd.c =================================================================== --- head/games/bcd/bcd.c (revision 241370) +++ head/games/bcd/bcd.c (working copy) @@ -129,9 +129,6 @@ { char cardline[80]; - /* revoke setgid privileges */ - setgid(getgid()); - /* * The original bcd prompts with a "%" when reading from stdin, * but this seems kind of silly. So this one doesn't. Index: head/games/caesar/caesar.c =================================================================== --- head/games/caesar/caesar.c (revision 241370) +++ head/games/caesar/caesar.c (working copy) @@ -82,9 +82,6 @@ char *inbuf; int obs[26], try, winner; - /* revoke setgid privileges */ - setgid(getgid()); - if (argc > 1) printit(argv[1]); >Release-Note: >Audit-Trail: >Unformatted: