From owner-cvs-all@FreeBSD.ORG Mon Jul 19 13:18:53 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3723D16A4D4 for ; Mon, 19 Jul 2004 13:18:53 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3EC543D49 for ; Mon, 19 Jul 2004 13:18:52 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 32106 invoked from network); 19 Jul 2004 13:18:52 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 Jul 2004 13:18:52 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i6JDIa1P011980; Mon, 19 Jul 2004 09:18:49 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 19 Jul 2004 09:19:48 -0400 User-Agent: KMail/1.6 References: <20040715050225.GA87532@freefall.freebsd.org> <200407151415.03555.jhb@FreeBSD.org> <20040715212836.GT95729@elvis.mu.org> In-Reply-To: <20040715212836.GT95729@elvis.mu.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200407190919.48876.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 13:18:53 -0000 On Thursday 15 July 2004 05:28 pm, Alfred Perlstein wrote: > * John Baldwin [040715 11:56] wrote: > > On Thursday 15 July 2004 01:29 am, Alfred Perlstein wrote: > > > > Also, why do you copy the proc name to the stack lower in > > > > kern_shutdown.c? Do you fear that the proc might change from > > > > under you when you're at the bottom and you can't therefore > > > > only keep a reference to the proc instead? > > > > > > Because I don't know if the proc will be there after it nukes itself. > > > > They don't nuke themselves, they just go to sleep. A quick look at the > > code would have revealed this. > > y'know what, in the context of fixing a printf I wasn't really > interested in looking that far into the scheduler. A 20 char stack > variable and a string copy at shutdown isn't such a big deal. If it > bugs you guys that much, why don't you just fix it? > > Or are you worried about getting 15 emails about how you inefficiently > printing a non-critical string like I have? :) No, I'm bothered that you are committing to code without understanding how it works or bothering to take the five minutes to read up on it to clear up the lack of understanding (which you are perfectly capable of doing.. the kproc suspend stuff isn't exactly rocket science). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org