From owner-svn-ports-head@FreeBSD.ORG  Mon Jan 27 10:36:54 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 4FB55F3C; Mon, 27 Jan 2014 10:36:54 +0000 (UTC)
Date: Mon, 27 Jan 2014 10:36:54 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r341341 - head/devel/xwpe
Message-ID: <20140127103654.GA12714@FreeBSD.org>
References: <201401270841.s0R8fjq3007225@svn.freebsd.org>
 <20140127092855.GA88072@FreeBSD.org>
 <20140127102231.GD30300@ithaqua.etoilebsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140127102231.GD30300@ithaqua.etoilebsd.net>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jan 2014 10:36:54 -0000

On Mon, Jan 27, 2014 at 11:22:31AM +0100, Baptiste Daroussin wrote:
> This particular port is a bit special as the DESTDIR variable is already
> defined it but for something totally different, thus I decided to inject a
> variable named STAGEDIR instead that is why I defined DESTDIRNAME to
> STAGEDIR in the makefile.

OK, fair enough. :)  Thanks for replying back.

> Your remark is valid is still valid for ports doing
> --prefix=${STAGEDIR}${PREFIX} which is often wrong but not for those doing
> --prefix=\$${STAGEDIR}${PREFIX} :)

I've just checked StageDir wiki page again; it seems that it already
contains instructions on how to verify that STAGEDIR does not sneak inside
the binaries (via bzgrep vs. my own handcrafted strings-based approach).

./danfe