From owner-svn-src-all@FreeBSD.ORG Mon Dec 23 11:35:57 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F39551D; Mon, 23 Dec 2013 11:35:57 +0000 (UTC) Received: from mail-ea0-x233.google.com (mail-ea0-x233.google.com [IPv6:2a00:1450:4013:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4AB5E1554; Mon, 23 Dec 2013 11:35:56 +0000 (UTC) Received: by mail-ea0-f179.google.com with SMTP id r15so2279281ead.24 for ; Mon, 23 Dec 2013 03:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=/K5RpAobSt7ks66/YYCrzp82e+9yGRF55tzgOQ7Eay0=; b=U+Uw4FXYY2huYwz7vHkfo5NzlDKvBWpNHJ4fKHibVuB2jZ5CHacLs+KO4Tg0Z36reg J4SqVw5p54sN3rfsNQmSazt4pQFdCOPL9/aRWYyPKyil8RDRU3tQj5W/bfP/zQouPr1/ WcSXUrLuX167y5Q6Iovpcm/auK2S8lGDscTQud5UBPLJ3lRASsOe9hZ1DrwsVIchEe5Y +lXAsGQ7+Dprs/rbQeQ6QB/C0iCatPQZEESSa+cPjUBb5/KgcY/K7JSd5cYyPhBVpfAo 8FyfuMKjz2F4I2NiYnB6mOhEor8RVFHvQPMCk7pjFF4AGpsq3MXNSLjO90P6iOFBCcmN Uq3w== X-Received: by 10.14.184.66 with SMTP id r42mr617586eem.86.1387798554596; Mon, 23 Dec 2013 03:35:54 -0800 (PST) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by mx.google.com with ESMTPSA id v1sm44766781eef.9.2013.12.23.03.35.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Dec 2013 03:35:53 -0800 (PST) Sender: Alexander Motin Message-ID: <52B82017.1040706@FreeBSD.org> Date: Mon, 23 Dec 2013 13:35:51 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r259765 - in head/sys: fs/nfsserver nfs nfsserver References: <201312230843.rBN8hHTx077901@svn.freebsd.org> <20131223111450.GB59496@kib.kiev.ua> In-Reply-To: <20131223111450.GB59496@kib.kiev.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Dec 2013 11:35:57 -0000 On 23.12.2013 13:14, Konstantin Belousov wrote: > On Mon, Dec 23, 2013 at 08:43:17AM +0000, Alexander Motin wrote: >> Author: mav >> Date: Mon Dec 23 08:43:16 2013 >> New Revision: 259765 >> URL: http://svnweb.freebsd.org/changeset/base/259765 >> >> Log: >> Fix RPC server threads file handle affinity to work better with ZFS. >> >> Instead of taking 8 specific bytes of file handle to identify file during >> RPC thread affitinity handling, use trivial hash of the full file handle. >> ZFS's struct zfid_short does not have padding field after the length field, >> as result, originally picked 8 bytes are loosing lower 16 bits of object ID, >> causing many false matches and unneeded requests affinity to same thread. >> This fix substantially improves NFS server latency and scalability in SPEC >> NFS benchmark by more flexible use of multiple NFS threads. >> >> Sponsored by: iXsystems, Inc. > > Did you audited all other filesystems to ensure that struct fid. > fid_data0 is filled (zeroed) consistently ? Yes, I did a tree search and in all found cases the structure was pre-erased. > Also, this constitues subtle VFS KBI change. In what way it touched VFS KBI? I indeed modified RPC FHA KPI to make it more safe, but I don't see how it may touch anything else then two of our NFS servers. -- Alexander Motin