From owner-cvs-src@FreeBSD.ORG Mon Oct 17 11:31:12 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7BD616A41F; Mon, 17 Oct 2005 11:31:12 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc14.comcast.net [216.148.227.89]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0930143D49; Mon, 17 Oct 2005 11:31:11 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-135.hsd1.ma.comcast.net ([24.147.19.135]) by comcast.net (rwcrmhc14) with ESMTP id <2005101711311001400kkt0re>; Mon, 17 Oct 2005 11:31:11 +0000 Received: from c-24-147-19-135.hsd1.ma.comcast.net (localhost.127.in-addr.arpa [127.0.0.1]) by c-24-147-19-135.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id j9HBVAbr003008; Mon, 17 Oct 2005 07:31:10 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-135.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-135.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id j9HBVARY003007; Mon, 17 Oct 2005 07:31:10 -0400 (EDT) (envelope-from rodrigc) Date: Mon, 17 Oct 2005 07:31:09 -0400 From: Craig Rodrigues To: Gleb Smirnoff Message-ID: <20051017113109.GA2986@crodrigues.org> References: <200510170327.j9H3RZeB020269@repoman.freebsd.org> <20051017064447.GN14542@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051017064447.GN14542@cell.sick.ru> User-Agent: Mutt/1.4.2.1i Cc: Craig Rodrigues , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 11:31:13 -0000 On Mon, Oct 17, 2005 at 10:44:47AM +0400, Gleb Smirnoff wrote: > C> This eliminates KASSERTs in GEOM if we accidentally mount an audio CD > C> as a cd9660 filesystem. > > Thanks for fixing this! I think it deserves to be merged to 6.0-RELEASE. > The operating system that panics on attempt to mount an audio CD looks funny. I think it is too late for merging this to 6.0-RELEASE and don't want this to hold up the release. It can be merged to RELENG_6 after the release. KASSERT() is only defined if you have INVARIANTS set, so it is not going to cause panics for the default kernel config for 6.0-RELEASE . -- Craig Rodrigues rodrigc@crodrigues.org