From owner-cvs-src@FreeBSD.ORG Fri Jun 15 21:24:43 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D8C6816A41F; Fri, 15 Jun 2007 21:24:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 79FFF13C46E; Fri, 15 Jun 2007 21:24:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l5FLOcq8038349; Fri, 15 Jun 2007 17:24:39 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Randall Stewart Date: Fri, 15 Jun 2007 17:22:45 -0400 User-Agent: KMail/1.9.6 References: <200706142259.l5EMx4aW053356@repoman.freebsd.org> <200706151340.29868.jhb@freebsd.org> <4672FC0B.1090907@cisco.com> In-Reply-To: <4672FC0B.1090907@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200706151722.46111.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 15 Jun 2007 17:24:39 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3430/Fri Jun 15 15:21:11 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Randall Stewart , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Kris Kennaway Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_uio.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 21:24:44 -0000 On Friday 15 June 2007 04:52:27 pm Randall Stewart wrote: > John Baldwin wrote: > > > > > Also, I would use KTR_SCTP and use the same #ifdef above so it is 0 or > > KTR_SUBSYS depending on whether or not you want it enabled. > > > > Changing the name around is cosmetic.. and no problem.. > > The actual ifdef with 0, though.. we have a seperate > mask.. since there are 21 or so things that can be logged/traced > and they all generate quite a bit of output.. which can be graphed > and charted.. along with the usual debugging lot.. > > Thus there is a seperate mask that turns these on/off.. > > So .. if for instance you enable KTR_SUBSYS (aka KTR_SCTP) then > nothing will come out until you enable the various logging > levels in SCTP. Ah, ok, in that case you are probably fine w/o the #ifdef. -- John Baldwin