From owner-freebsd-bugs@FreeBSD.ORG  Thu Nov 27 15:17:45 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 41CEA1065677
	for <freebsd-bugs@freebsd.org>; Thu, 27 Nov 2008 15:17:45 +0000 (UTC)
	(envelope-from onemda@gmail.com)
Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.31])
	by mx1.freebsd.org (Postfix) with ESMTP id EFD448FC0A
	for <freebsd-bugs@freebsd.org>; Thu, 27 Nov 2008 15:17:44 +0000 (UTC)
	(envelope-from onemda@gmail.com)
Received: by yw-out-2324.google.com with SMTP id 9so457545ywe.13
	for <freebsd-bugs@freebsd.org>; Thu, 27 Nov 2008 07:17:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to
	:subject:mime-version:content-type:content-transfer-encoding
	:content-disposition;
	bh=dW2N6XyhtlRjPrDO5XQ9Qpth3uzISeVH/JK/aeA0dg8=;
	b=oN0jbuOQ21Ip+OWO6z7CkAjWDcoKDLAUrz5dzdr0YUI/QTN/ZiipH/LMBLOmxRtzSl
	WUjECH6hdpAxYJj1o2QqosMx1Hjn3uYecngrkCCwvtKpvWCF/66OzprqUZrkJal/DCIr
	fhNstULVb2MdAwqZlX6dRY8aeiyvI5XOHcOG8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:mime-version:content-type
	:content-transfer-encoding:content-disposition;
	b=BeCFj6HSmDqdAKhID0V3HvBKrQwv3ZX1M/4RgssLSMVEl8PxSINxFYCvoTj087DktJ
	6gijtEERAEfbAcH1BWEldj2yubsfgzVsDmlmhk6RHtLeiMJHFbW/m0+Khnd9JhTNn8X6
	fDkyfrUAqMWjwBdNNbPr13Vzfm/9Jk13GcnMY=
Received: by 10.231.14.196 with SMTP id h4mr5397iba.15.1227797564365;
	Thu, 27 Nov 2008 06:52:44 -0800 (PST)
Received: by 10.231.10.65 with HTTP; Thu, 27 Nov 2008 06:52:44 -0800 (PST)
Message-ID: <3a142e750811270652i6fbfaab9wd708148d7507c1ec@mail.gmail.com>
Date: Thu, 27 Nov 2008 15:52:44 +0100
From: "Paul B. Mahol" <onemda@gmail.com>
To: freebsd-bugs@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: kern/127411: [ata] [panic] ata panics on bad block
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2008 15:17:45 -0000

Fixed by following change:

Date: Thu Nov 27 03:37:46 2008
New Revision: 185357
URL: http://svn.freebsd.org/changeset/base/185357

Log:
  Don't let ata_completed() dereference a null request->dma pointer to
  print dma status after a media error.

Modified:
  h
@@ -357,7 +357,7 @@ ata_completed(void *context, int dummy)
                              "\6MEDIA_CHANGED\5NID_NOT_FOUND"
                              "\4MEDIA_CHANGE_REQEST"
                              "\3ABORTED\2NO_MEDIA\1ILLEGAL_LENGTH");
-               if ((request->flags & ATA_R_DMA) &&
+               if ((request->flags & ATA_R_DMA) && request->dma &&
                    (request->dma->status & ATA_BMSTAT_ERROR))
                    printf(" dma=0x%02x", request->dma->status);
                if (!(request->flags & (ATA_R_ATAPI | ATA_R_CONTROL)))


-- 
Paul