From owner-freebsd-arch@FreeBSD.ORG  Tue Sep  4 16:45:30 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E8073106566B;
	Tue,  4 Sep 2012 16:45:30 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id E36DB8FC14;
	Tue,  4 Sep 2012 16:45:29 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA07316;
	Tue, 04 Sep 2012 19:45:27 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <50463026.8000506@FreeBSD.org>
Date: Tue, 04 Sep 2012 19:45:26 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:15.0) Gecko/20120830 Thunderbird/15.0
MIME-Version: 1.0
To: Andrey Zonov <zont@FreeBSD.org>
References: <503DD433.2030108@FreeBSD.org>
	<201208290906.q7T96C9j032802@gw.catspoiler.org>
	<20120829092318.GW33100@deviant.kiev.zoral.com.ua>
	<503F2D24.8050103@FreeBSD.org>
In-Reply-To: <503F2D24.8050103@FreeBSD.org>
X-Enigmail-Version: 1.4.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: freebsd-arch@FreeBSD.org
Subject: Re: [patch] unprivileged mlock(2)
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2012 16:45:31 -0000

on 30/08/2012 12:06 Andrey Zonov said the following:
> Hi,
> 
> So, I've got the first version of the patch (attached) which fixes
> memory locked limit checking and accounting.

Andrey,

your mlock.patch looks good to me, but I haven't verified pieces under RACCT.
Please try to get a review from a person who is knee-deep in the VM code like alc
or your mentor.

The code should also be sent for vetoing to security@.  Not sure if you would get
a review there, but absence of nays would be good.

When the code is ready to be committed, please remember about
memorylocked=unlimited in the default entry of the default login.conf.  A big
warning about it will have to be posted (in UPDATING and current@/stable@ at the
very least).

Thank you very much for doing this work.

P.S.  It would probably make sense to provide some HTTP home for this patch as well.

-- 
Andriy Gapon