From owner-svn-src-all@FreeBSD.ORG Sun Oct 13 17:03:14 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 49E604A2; Sun, 13 Oct 2013 17:03:14 +0000 (UTC) (envelope-from mark@grondar.org) Received: from gromit.grondar.org (grandfather.grondar.org [IPv6:2a01:348:0:15:5d59:5c20:0:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0A7452C86; Sun, 13 Oct 2013 17:03:14 +0000 (UTC) Received: from graveyard.grondar.org ([88.96.155.33] helo=gronkulator.grondar.org) by gromit.grondar.org with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1VVP4Q-000Pd7-UD; Sun, 13 Oct 2013 18:03:12 +0100 Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: multipart/signed; boundary="Apple-Mail=_87756473-C158-4388-B9D7-DFD088119C78"; protocol="application/pgp-signature"; micalg=pgp-sha512 From: Mark R V Murray In-Reply-To: <1381681119.42859.33.camel@revolution.hippie.lan> Date: Sun, 13 Oct 2013 18:03:09 +0100 Message-Id: <6E7CF22B-B83B-4F31-955D-DC64441FAC8D@grondar.org> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> <20131013151359.GR41229@kib.kiev.ua> <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> <1381681119.42859.33.camel@revolution.hippie.lan> To: Ian Lepore X-Mailer: Apple Mail (2.1510) X-SA-Score: -2.2 Cc: Konstantin Belousov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2013 17:03:14 -0000 --Apple-Mail=_87756473-C158-4388-B9D7-DFD088119C78 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 13 Oct 2013, at 17:18, Ian Lepore wrote: > On Sun, 2013-10-13 at 16:18 +0100, Mark R V Murray wrote: >> On 13 Oct 2013, at 16:13, Konstantin Belousov wrote: >>> Surely this works, thank you. The rwfile.c content probably should be >>> taken under the #ifdef RANDOM_RWFILE. >> >> OK - thanks for the feedback! >> >>> But I do not see much use for the randomdev_read_file() and >>> randomdev_write_file() functions. It would be better to directly code >>> the VFS calls in the random_harvestq_cache(). For one thing, it would >>> eliminate unneccessary close and open of the entropy file. >> >> There is some uncertainty about the future of that code, so I want >> to keep it that way for now. Writing files from the kernel is making so@ >> very uncomfortable, and there is too much scope for error there. >> > > Indeed, it makes me nervous too, as a heavy user of readonly root > filesystems. If writing this file is so critical that it has to be done > by the kernel, then what happens when it fails? Right now it prints an > error and continues -- if it is not so critical that failure means > panic, then why is the kernel doing it at all? Good points all. The intent is not to win the arms-race outright, but to win the common-case battles as convincingly as possible. That said, its not looking good for the process, but I still want to give it a decent look before/if yanking it. > Why is the file even in the root filesystem? /var/db seems to be the > right place for a transient file needed by the system. Because that appears to be the best place to put first-boot entropy from sysinstall/bsdinstall. /var/db/entropy/... will also be used if possible; watch this space. > Speaking of errors, that might include things like the current code > calling vn_close() with the FREAD flag on a file open for writing. Thanks :-( :-) M -- Mark R V Murray --Apple-Mail=_87756473-C158-4388-B9D7-DFD088119C78 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: GPGTools - http://gpgtools.org iQCVAwUBUlrSTd58vKOKE6LNAQpvzQP+I3nvSu7JThCmaWGYqnWh/dE0O8QFGrAL 3jMMuuNVeKIF4kRy6c2HiFLC6u64XEi40pbjVT20zNCFa0lTV+RP578ZgMl6tef5 Cnfn3X6h49Rqlsfaz3g+rFtVLDBjcNMICk8UAMN5uQBsAfXDjs1IkMCYhmQeeMXF lLqCE6iAUOU= =ais7 -----END PGP SIGNATURE----- --Apple-Mail=_87756473-C158-4388-B9D7-DFD088119C78--